[U-Boot] [PATCH] Blackfin: bf537-stamp: fix I2C board defines

[U-Boot] [PATCH] Blackfin: bf537-stamp: fix I2C board defines

[Mike Frysinger]

The previous merge for cleaning up the I2C driver incorrectly reverted the
CFG_xxx rename for some of the I2C defines.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 include/configs/bf537-stamp.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/configs/bf537-stamp.h b/include/configs/bf537-stamp.h
index 27567fa..f6399a9 100644
--- a/include/configs/bf537-stamp.h
+++ b/include/configs/bf537-stamp.h
@@ -308,8 +308,8 @@
  */
 #define CONFIG_HARD_I2C		1
 #define CONFIG_BFIN_TWI_I2C	1
-#define CFG_I2C_SPEED		50000
-#define CFG_I2C_SLAVE		0
+#define CONFIG_SYS_I2C_SPEED	50000
+#define CONFIG_SYS_I2C_SLAVE	0
 
 #define CONFIG_EBIU_SDRRC_VAL  0x306
 #define CONFIG_EBIU_SDGCTL_VAL 0x91114d
-- 
1.6.1.3

[U-Boot] [PATCH] Blackfin: bf537-stamp: fix I2C board defines

[Heiko Schocher]

Hello Mike,

Mike Frysinger wrote:
> The previous merge for cleaning up the I2C driver incorrectly reverted the
> CFG_xxx rename for some of the I2C defines.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  include/configs/bf537-stamp.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/configs/bf537-stamp.h b/include/configs/bf537-stamp.h
> index 27567fa..f6399a9 100644
> --- a/include/configs/bf537-stamp.h
> +++ b/include/configs/bf537-stamp.h
> @@ -308,8 +308,8 @@
>   */
>  #define CONFIG_HARD_I2C		1
>  #define CONFIG_BFIN_TWI_I2C	1
> -#define CFG_I2C_SPEED		50000
> -#define CFG_I2C_SLAVE		0
> +#define CONFIG_SYS_I2C_SPEED	50000
> +#define CONFIG_SYS_I2C_SLAVE	0
>  
>  #define CONFIG_EBIU_SDRRC_VAL  0x306
>  #define CONFIG_EBIU_SDGCTL_VAL 0x91114d
>   


This go through your tree, right? If so you have my

Signed-off-by: Heiko Schocher <hs@denx.de>

bye
Heiko

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany 

[U-Boot] [PATCH] Blackfin: bf537-stamp: fix I2C board defines

[Mike Frysinger]

On Thursday 19 February 2009 03:35:28 Heiko Schocher wrote:
> Mike Frysinger wrote:
> > The previous merge for cleaning up the I2C driver incorrectly reverted
> > the CFG_xxx rename for some of the I2C defines.
> >
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> > ---
> >  include/configs/bf537-stamp.h |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/configs/bf537-stamp.h
> > b/include/configs/bf537-stamp.h index 27567fa..f6399a9 100644
> > --- a/include/configs/bf537-stamp.h
> > +++ b/include/configs/bf537-stamp.h
> > @@ -308,8 +308,8 @@
> >   */
> >  #define CONFIG_HARD_I2C		1
> >  #define CONFIG_BFIN_TWI_I2C	1
> > -#define CFG_I2C_SPEED		50000
> > -#define CFG_I2C_SLAVE		0
> > +#define CONFIG_SYS_I2C_SPEED	50000
> > +#define CONFIG_SYS_I2C_SLAVE	0
> >
> >  #define CONFIG_EBIU_SDRRC_VAL  0x306
> >  #define CONFIG_EBIU_SDGCTL_VAL 0x91114d
>
> This go through your tree, right? If so you have my
>
> Signed-off-by: Heiko Schocher <hs@denx.de>

doesnt matter to me.  if it doesnt get merged, i'll post a pull request.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090219/96c9ba47/attachment.pgp 

[U-Boot] [PATCH] Blackfin: bf537-stamp: fix I2C board defines

[Wolfgang Denk]

Dear Mike Frysinger,

In message <200902191219.40041.vapier@gentoo.org> you wrote:
>
> > This go through your tree, right? If so you have my
> >
> > Signed-off-by: Heiko Schocher <hs@denx.de>
> 
> doesnt matter to me.  if it doesnt get merged, i'll post a pull request.

Ummm... Heiko is the I2C custodian, so his "Acked-By:"  (Heiko,  that
should have been an "Acked-By:", I think) is pretty important to you.
You  should  not  include  this  patc  into your repo without Heiko's
ACK...

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
NOTE: The  Most  Fundamental  Particles  in  This  Product  Are  Held
Together  by  a  "Gluing" Force About Which Little is Currently Known
and Whose Adhesive Power Can Therefore Not Be Permanently Guaranteed.

[U-Boot] [PATCH] Blackfin: bf537-stamp: fix I2C board defines

[Mike Frysinger]

On Thursday 19 February 2009 15:08:33 Wolfgang Denk wrote:
> In message Mike Frysinger wrote:
> > > This go through your tree, right? If so you have my
> > >
> > > Signed-off-by: Heiko Schocher <hs@denx.de>
> >
> > doesnt matter to me.  if it doesnt get merged, i'll post a pull request.
>
> Ummm... Heiko is the I2C custodian, so his "Acked-By:"  (Heiko,  that
> should have been an "Acked-By:", I think) is pretty important to you.
> You  should  not  include  this  patc  into your repo without Heiko's
> ACK...

i wasnt talking about his tag, i was talking about him merging it through the 
i2c tree or me through the Blackfin tree
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090219/61952b88/attachment.pgp 

[U-Boot] [PATCH] Blackfin: bf537-stamp: fix I2C board defines

[Heiko Schocher]

Hello Wolfgang,

Wolfgang Denk wrote:
> In message <200902191219.40041.vapier@gentoo.org> you wrote:
>>> This go through your tree, right? If so you have my
>>>
>>> Signed-off-by: Heiko Schocher <hs@denx.de>
>> doesnt matter to me.  if it doesnt get merged, i'll post a pull request.
> 
> Ummm... Heiko is the I2C custodian, so his "Acked-By:"  (Heiko,  that
> should have been an "Acked-By:", I think) is pretty important to you.
> You  should  not  include  this  patc  into your repo without Heiko's
> ACK...

OK, I am learning. So I give this patch a

Acked-By: Heiko Schocher <hs@denx.de>

and this patch can go through the Blackfin tree now, right?

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany