public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Richard Retanubun <RichardRetanubun@RuggedCom.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Cleanup the comment for m68k linux boot argument passing.
Date: Fri, 20 Feb 2009 12:15:22 -0500	[thread overview]
Message-ID: <499EE52A.50608@RuggedCom.com> (raw)
In-Reply-To: <200902201202.24598.vapier@gentoo.org>

Hi Mike,

wow, that a more rapid response that I am used to :)

Mike Frysinger wrote:
> On Friday 20 February 2009 11:34:06 Richard Retanubun wrote:
>>  From e2e085f8b8e638762c59b0bc5376b241b0046132 Mon Sep 17 00:00:00 2001
>> From: Richard Retanubun <RichardRetanubun@RuggedCom.com>
>> Date: Fri, 20 Feb 2009 11:06:36 -0500
>> Subject: [PATCH] Cleanup the comment for m68k linux boot argument passing.
>>
>>
>> Signed-off-by: Richard Retanubun <RichardRetanubun@RuggedCom.com>
>> ---
>> Hi Tsi-Chung,
>>
>> Thanks for the response, I found the solution after using a hw debugger to
>> step through the code. The one gotcha here is that the assembly instruction
>> that the compiler uses to jump to the kernel is 'jsr' which puts the next
>> instruction after the jsr into the stack pointer so there is an
>> 'off-by-one' effect from the stack pointer.
>>
>> This patch cleans up the comment to clarify the boot arg passing.
>> I'll try to push a patch for the kernel as well.
> 
> comments for the changelog go above the ---, not below

Yep, I thought this is what I did, the commit message is

"Cleanup the comment for m68k linux boot argument passing."

The stuff under the --- Is just continuing a conversation thread.
I tend to keep the commit message short and be more verbose in the
code comments.

> 
> use git and put it into the commit message:
> $ git commit --amend

Thanks for the tip. I'll submit a V2.
> blah blah the patch summary
> 
> a paragraph about the changes ....
> -mike

  reply	other threads:[~2009-02-20 17:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-13 16:57 [U-Boot] Coldfire: bootm: How does bootm pass bootargs to linux? Richard Retanubun
2009-02-19  0:07 ` TC Liew
2009-02-20 16:34   ` [U-Boot] [PATCH] Cleanup the comment for m68k linux boot argument passing Richard Retanubun
2009-02-20 17:02     ` Mike Frysinger
2009-02-20 17:15       ` Richard Retanubun [this message]
2009-02-20 17:22         ` [U-Boot] [PATCH V2] " Richard Retanubun
2009-02-20 17:41           ` Mike Frysinger
2009-02-20 18:01             ` Richard Retanubun
2009-02-21 22:50               ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=499EE52A.50608@RuggedCom.com \
    --to=richardretanubun@ruggedcom.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox