public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Query on timeouts with NetSetTimeout
Date: Sat, 21 Feb 2009 09:04:52 +0100	[thread overview]
Message-ID: <499FB5A4.6010606@googlemail.com> (raw)
In-Reply-To: <20090220070907.9EF0F832E43F@gemini.denx.de>

Hi Mani,

Wolfgang Denk wrote:
> Dear "Pillai, Manikandan",
> 
> In message <19F8576C6E063C45BE387C64729E739403FA90441B@dbde02.ent.ti.com> you wrote:
>>
>> The NetSetTimeout() invokes get_timer() to do its operations. The
>> get_timer() should return the counter value. It's not always true
>> that the counter runs at millisecond clock. I believe the earlier
> 
> We call this a bug, then. get_timer() is specified to return tick os
> one millisecond resolution.
> 
> If your code behaves differently, it needs to be fixed.
> 
>> versions of the NetSetTimeout calls in u-boot/net directory used to
>> have a multiple of CONFIG_SYS_HZ for timeout that could easily be
>> used to get required timeout for different platforms.
> 
> That code was cleaned up some time ago. If there are board ports
> which define CONFIG_SYS_HZ to anything else by the mandatory value
> of 1000 (like OMAP seems to do), then such ports are broken and need
> to be fixed.

Do you kindly like to look into the two issues Wolfgang mentions here, 
test and send a patch? Sounds like you understood the issue and can 
test it ;)

Many thanks

Dirk

P.S.: Looping in BeagleBoard list.

      reply	other threads:[~2009-02-21  8:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-20  3:51 [U-Boot] Query on timeouts with NetSetTimeout Pillai, Manikandan
2009-02-20  5:39 ` Ben Warren
2009-02-20  7:09 ` Wolfgang Denk
2009-02-21  8:04   ` Dirk Behme [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=499FB5A4.6010606@googlemail.com \
    --to=dirk.behme@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox