public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/7 v2] OMAP3: Add serial number based on die ID
Date: Sun, 22 Feb 2009 17:40:27 +0100	[thread overview]
Message-ID: <49A17FFB.8080602@googlemail.com> (raw)
In-Reply-To: <20090222160142.GE9867@game.jcrosoft.org>

Dear Wolfgang and Jean-Christophe,

Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 19:55 Thu 12 Feb     , Dirk Behme wrote:
>> Add serial number based on OMAP3 die ID.
>>
>> Signed-off-by: Dirk Behme <dirk.behme@googlemail.com>
>>
>> ---
>> Changes in v2:
>>
>> - Rename 'serial' to 'serial#'
>> - Don't copy from a memory to an other, instead just update the pointer
>>
>>  board/omap3/beagle/beagle.c            |    2 ++
>>  board/omap3/evm/evm.c                  |    2 ++
>>  board/omap3/overo/overo.c              |    2 ++
>>  board/omap3/pandora/pandora.c          |    2 ++
>>  board/omap3/zoom1/zoom1.c              |    1 +
>>  cpu/arm_cortexa8/omap3/sys_info.c      |   26 ++++++++++++++++++++++++++
>>  include/asm-arm/arch-omap3/cpu.h       |   13 +++++++++++++
>>  include/asm-arm/arch-omap3/omap3.h     |    1 +
>>  include/asm-arm/arch-omap3/sys_proto.h |    1 +
>>  9 files changed, 50 insertions(+)
>>
> report it as the CPU serial if you want but report it as the board serial make
> no sense to me

While discussing about this, please consider arguments/point of view 
given in

http://lists.denx.de/pipermail/u-boot/2009-February/047458.html

too.

Additionally, looking at description of "serial#" at

http://www.denx.de/wiki/DULG/UBootEnvVariables

I understand:

-> "serial#: contains hardware identification information such as type 
string and/or serial number."

With OMAP3 == hardware this is true for OMAP3 device ID, no?

-> "This variable can be set only once (usually during manufacturing 
of the board)."

This is true if OMAP3 is never exchanged as assumption in my comment

http://lists.denx.de/pipermail/u-boot/2009-February/047458.html

no?

Regards

Dirk

Btw.: I haven't got the point why the string 'serial#' applies only to 
a _board_ serial number, yet?

  reply	other threads:[~2009-02-22 16:40 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-12 18:55 [U-Boot] [PATCH 0/7 v2] OMAP3: Add some additional improvements and fixes Dirk Behme
2009-02-12 18:55 ` [U-Boot] [PATCH 1/7 v2] OMAP3: Overo: Clean up pin mux and GPIO configuration Dirk Behme
2009-02-12 18:55   ` [U-Boot] [PATCH 2/7 v2] OMAP3: Beagle: Add board revision detection Dirk Behme
2009-02-12 18:55     ` [U-Boot] [PATCH 3/7 v2] OMAP3: Add OMAP3 auto detection Dirk Behme
2009-02-12 18:55       ` [U-Boot] [PATCH 4/7 v2] OMAP3: Pandora: Update pin mux Dirk Behme
2009-02-12 18:55         ` [U-Boot] [PATCH 5/7 v2] OMAP3: Add serial number based on die ID Dirk Behme
2009-02-12 18:55           ` [U-Boot] [PATCH 6/7 v2] OMAP3: Add OMAP3 core changes for MUSB Dirk Behme
2009-02-12 18:55             ` [U-Boot] [PATCH 7/7 v2] OMAP3: Clean up MMC code Dirk Behme
2009-02-22 15:59             ` [U-Boot] [PATCH 6/7 v2] OMAP3: Add OMAP3 core changes for MUSB Jean-Christophe PLAGNIOL-VILLARD
2009-02-22 16:22               ` Dirk Behme
2009-02-23 12:13                 ` Grazvydas Ignotas
2009-02-23 12:30                   ` Nishanth Menon
2009-02-23 19:31                     ` Dirk Behme
2009-02-23 21:36                     ` Wolfgang Denk
2009-02-23 23:03                       ` [U-Boot] Clock handling (wasRe: [PATCH 6/7 v2] OMAP3: Add OMAP3 core changes for MUSB) Nishanth Menon
2009-02-24 17:01                         ` Dirk Behme
2009-02-24 17:01                       ` [U-Boot] [PATCH 6/7 v2] OMAP3: Add OMAP3 core changes for MUSB Dirk Behme
2009-02-24 21:22                         ` Wolfgang Denk
2009-02-25 17:39                           ` Dirk Behme
2009-03-01 14:26                             ` Dirk Behme
2009-03-01 19:18                               ` Wolfgang Denk
2009-03-11 14:46             ` Jean-Christophe PLAGNIOL-VILLARD
2009-03-11 18:25               ` Dirk Behme
2009-03-11 18:44                 ` Wolfgang Denk
2009-02-22 16:01           ` [U-Boot] [PATCH 5/7 v2] OMAP3: Add serial number based on die ID Jean-Christophe PLAGNIOL-VILLARD
2009-02-22 16:40             ` Dirk Behme [this message]
2009-02-22 21:44             ` Wolfgang Denk
2009-03-01 14:20               ` Dirk Behme
2009-03-01 18:57                 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49A17FFB.8080602@googlemail.com \
    --to=dirk.behme@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox