[U-Boot] [PATCH 6/7 v2] OMAP3: Add OMAP3 core changes for MUSB

Dirk Behme
2009-03-01T14:26:33Z

Dirk Behme wrote:
> Wolfgang Denk wrote:
...
>>> Other point of view of "enabling clock only if need" can be "enable
>>> clock only if code is compiled into uboot _and_ is accessed (e.g. by
>>> serial output over USB)" (i.e. runtime enable). I think this what
>>
>> Yes, that is the intention.
>
> Will it get an ACK if we change
>
> --- u-boot-main.orig/cpu/arm_cortexa8/omap3/clock.c
> +++ u-boot-main/cpu/arm_cortexa8/omap3/clock.c
> @@ -377,5 +377,10 @@ void per_clocks_enable(void)
> sr32(&prcm_base->fclken_per, 0, 32, FCK_PER_ON);
> sr32(&prcm_base->iclken_per, 0, 32, ICK_PER_ON);
>
> +#ifdef CONFIG_MUSB
> + /* Enable the MUSB interface clock */
> + sr32(&prcm_base->iclken1_core, 4, 1, 0x1);
> +#endif
>
> to something like
>
> +++ u-boot-main/cpu/arm_cortexa8/omap3/clock.c
> #ifdef CONFIG_MUSB
> void enable_musb_clock(void) {
> sr32(&prcm_base->iclken1_core, 4, 1, 0x1);
> }
>
> void disable_musb_clock(void) {
> sr32(&prcm_base->iclken1_core, 4, 1, 0x0);
> }
> #endif
>
> and then call enable/disable from MUSB code at appropriate places?

Any hint if changing the patch doing something like above as proposed
some days ago [1] would get an ack?

Thanks

Dirk

[1] http://lists.denx.de/pipermail/u-boot/2009-February/048482.html