[U-Boot] [PATCH 6/7 v2] OMAP3: Add OMAP3 core changes for MUSB

Grazvydas Ignotas
2009-02-23T12:13:20Z

On Sun, Feb 22, 2009 at 6:22 PM, Dirk Behme <dirk.behme@googlemail.com> wrote:
> Dear Jean-Christophe,
>
> Jean-Christophe PLAGNIOL-VILLARD wrote:
>> On 19:55 Thu 12 Feb , Dirk Behme wrote:
>>> OMAP3 core changes necessary for MUSB
>>>
>>> Signed-off-by: Dirk Behme <dirk.behme@googlemail.com>
>>>
>>> ---
>>> Note: OMAP3 USB code will be sent later to USB maintainer, so
>>> CONFIG_MUSB isn't used anywhere yet. This will avoid
>>> USB maintainer to change OMAP3 core files.
>>>
>>> cpu/arm_cortexa8/omap3/clock.c | 5 +++++
>>> include/asm-arm/arch-omap3/cpu.h | 2 ++
>>> include/asm-arm/arch-omap3/omap3.h | 11 +++++++++++
>>> 3 files changed, 18 insertions(+)
>>>
>>> Index: u-boot-main/cpu/arm_cortexa8/omap3/clock.c
>>> ===================================================================
>>> --- u-boot-main.orig/cpu/arm_cortexa8/omap3/clock.c
>>> +++ u-boot-main/cpu/arm_cortexa8/omap3/clock.c
>>> @@ -377,5 +377,10 @@ void per_clocks_enable(void)
>>> sr32(&prcm_base->fclken_per, 0, 32, FCK_PER_ON);
>>> sr32(&prcm_base->iclken_per, 0, 32, ICK_PER_ON);
>>>
>>> +#ifdef CONFIG_MUSB
>>> + /* Enable the MUSB interface clock */
>>> + sr32(&prcm_base->iclken1_core, 4, 1, 0x1);
>>> +#endif
>> the design of u-boot is to enagle the IP only when he use it
>> so please do not enable the clock every time just when you want to use
>> (in the USB driver init)
>
> This is already answered in
>
> http://lists.denx.de/pipermail/u-boot/2009-February/047452.html

He probably wants to say that clocks should be enabled only when "usb
start" is issued, as you might have u-boot compiled with USB defines
set, but never actually use USB.