* [U-Boot] [PATCH] sh: Add support sh_eth to cpu of sh4
@ 2009-02-24 7:20 Nobuhiro Iwamatsu
2009-02-24 7:32 ` Mike Frysinger
0 siblings, 1 reply; 3+ messages in thread
From: Nobuhiro Iwamatsu @ 2009-02-24 7:20 UTC (permalink / raw)
To: u-boot
Signed-off-by: Nobuhiro Iwamatsu <iwamatsu.nobuhiro@renesas.com>
---
cpu/sh4/cpu.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/cpu/sh4/cpu.c b/cpu/sh4/cpu.c
index 52b6cfd..be410ab 100644
--- a/cpu/sh4/cpu.c
+++ b/cpu/sh4/cpu.c
@@ -23,6 +23,7 @@
#include <common.h>
#include <command.h>
+#include <netdev.h>
#include <asm/processor.h>
#include <asm/cache.h>
-- 1.5.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] sh: Add support sh_eth to cpu of sh4
2009-02-24 7:20 [U-Boot] [PATCH] sh: Add support sh_eth to cpu of sh4 Nobuhiro Iwamatsu
@ 2009-02-24 7:32 ` Mike Frysinger
2009-02-24 7:38 ` Nobuhiro Iwamatsu
0 siblings, 1 reply; 3+ messages in thread
From: Mike Frysinger @ 2009-02-24 7:32 UTC (permalink / raw)
To: u-boot
On Tuesday 24 February 2009 02:20:40 Nobuhiro Iwamatsu wrote:
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu.nobuhiro@renesas.com>
> ---
> cpu/sh4/cpu.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/cpu/sh4/cpu.c b/cpu/sh4/cpu.c
> index 52b6cfd..be410ab 100644
> --- a/cpu/sh4/cpu.c
> +++ b/cpu/sh4/cpu.c
> @@ -23,6 +23,7 @@
>
> #include <common.h>
> #include <command.h>
> +#include <netdev.h>
> #include <asm/processor.h>
> #include <asm/cache.h>
this change doesnt really seem to jive with the changelog. adding a header
implies fixing of warning/build breakage, not "Add support sh_eth to cpu of
sh4" ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090224/6418f98f/attachment.pgp
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] sh: Add support sh_eth to cpu of sh4
2009-02-24 7:32 ` Mike Frysinger
@ 2009-02-24 7:38 ` Nobuhiro Iwamatsu
0 siblings, 0 replies; 3+ messages in thread
From: Nobuhiro Iwamatsu @ 2009-02-24 7:38 UTC (permalink / raw)
To: u-boot
Mike Frysinger wrote:
> On Tuesday 24 February 2009 02:20:40 Nobuhiro Iwamatsu wrote:
>> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu.nobuhiro@renesas.com>
>> ---
>> cpu/sh4/cpu.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/cpu/sh4/cpu.c b/cpu/sh4/cpu.c
>> index 52b6cfd..be410ab 100644
>> --- a/cpu/sh4/cpu.c
>> +++ b/cpu/sh4/cpu.c
>> @@ -23,6 +23,7 @@
>>
>> #include <common.h>
>> #include <command.h>
>> +#include <netdev.h>
>> #include <asm/processor.h>
>> #include <asm/cache.h>
>
> this change doesnt really seem to jive with the changelog. adding a header
> implies fixing of warning/build breakage, not "Add support sh_eth to cpu of
> sh4" ...
> -mike
Thanks,
I will change changelog and resend.
Best regards,
Nobuhiro
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-02-24 7:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-24 7:20 [U-Boot] [PATCH] sh: Add support sh_eth to cpu of sh4 Nobuhiro Iwamatsu
2009-02-24 7:32 ` Mike Frysinger
2009-02-24 7:38 ` Nobuhiro Iwamatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox