public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/9 v3] 83xx, i2c: add mux support for fsl_i2c
Date: Tue, 24 Feb 2009 08:53:33 +0100	[thread overview]
Message-ID: <49A3A77D.4090704@denx.de> (raw)
In-Reply-To: <20090223163548.7bcc21b6.kim.phillips@freescale.com>

Hello Kim,

Kim Phillips wrote:
> On Thu, 19 Feb 2009 17:24:09 +0100
> Heiko Schocher <hs@denx.de> wrote:
[...]
>>  unsigned int i2c_get_bus_num(void)
>>  {
>> +#if defined(CONFIG_I2C_MUX)
>> +	return i2c_bus_num_mux;
>> +#else
>>  	return i2c_bus_num;
>> +#endif
>>  }
> 
> I don't get this mux variant - why aren't we reusing i2c_bus_num in the
> mux case?

Because i2c_bus_num is used as an index which hardware i2c controller
is used (0 or 1). In CONFIG_I2C_MUX case, you have more than 2 i2c
busses -> i2c_bus_num would be greater than 1, so you must have a
variable, where you store which hardware adapter you use, and one
which stores on which i2c bus you are.

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  parent reply	other threads:[~2009-02-24  7:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-19 16:24 [U-Boot] [PATCH 4/9 v3] 83xx, i2c: add mux support for fsl_i2c Heiko Schocher
2009-02-23 22:35 ` Kim Phillips
2009-02-24  7:00   ` Heiko Schocher
2009-02-24  7:53   ` Heiko Schocher [this message]
2009-02-25  0:08     ` Kim Phillips
2009-02-25  8:00       ` Heiko Schocher
2009-02-26  1:20         ` Timur Tabi
2009-02-26  7:05           ` Heiko Schocher
2009-02-26  1:31         ` Kim Phillips
2009-02-26  7:09           ` Heiko Schocher
2009-02-23 22:43 ` Kim Phillips
2009-02-24  1:49 ` Timur Tabi
2009-02-24  7:54   ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49A3A77D.4090704@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox