public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/9 v3] 83xx, i2c: add mux support for fsl_i2c
Date: Thu, 26 Feb 2009 08:09:06 +0100	[thread overview]
Message-ID: <49A64012.1020801@denx.de> (raw)
In-Reply-To: <20090225193153.a7caaf66.kim.phillips@freescale.com>

Hello Kim,

Kim Phillips wrote:
> On Wed, 25 Feb 2009 09:00:39 +0100
> Heiko Schocher <hs@denx.de> wrote:
> 
>>> so instead of naming it "i2c_bus_num_mux" it should be renamed
>>> "i2c_adapter_num"?, or does i2c_get_bus_num() still imply that it will
>> No, i2c_adapter_num should be 0 or 1 for Controller 0 or 1, I think,
>> and i2c_bus_num_mux can be greater then 1.
>>
>> If we would do a rename, we should rename "i2c_bus_num" to "i2c_adapter_num".
>> In case, we don;t use i2c mux, i2c_bus_num = i2c_adapter_num.
>> else i2c_bus_num >= i2c_adapter_num (=0 or 1)
> 
> sigh..that's not really that better either.

yes, sorry.

>>> altogether?
>> We should rework this "i2c multibus" instead complete, so we can remove
>> all this instances from i2c_get_bus_num()/i2c_set_bus_num() in every
>> i2c driver ... such an attempt was in discussion, but unfortunately
>> failed ... but I hope I can retrigger it.
> 
> ok - looking forward to it.

Yep, I hope to get this running on beginning of march, and this approach,
hopefully, solves a lot of this problems.

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2009-02-26  7:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-19 16:24 [U-Boot] [PATCH 4/9 v3] 83xx, i2c: add mux support for fsl_i2c Heiko Schocher
2009-02-23 22:35 ` Kim Phillips
2009-02-24  7:00   ` Heiko Schocher
2009-02-24  7:53   ` Heiko Schocher
2009-02-25  0:08     ` Kim Phillips
2009-02-25  8:00       ` Heiko Schocher
2009-02-26  1:20         ` Timur Tabi
2009-02-26  7:05           ` Heiko Schocher
2009-02-26  1:31         ` Kim Phillips
2009-02-26  7:09           ` Heiko Schocher [this message]
2009-02-23 22:43 ` Kim Phillips
2009-02-24  1:49 ` Timur Tabi
2009-02-24  7:54   ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49A64012.1020801@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox