From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dirk Behme <dirk.behme@googlemail.com>
Date: Sun, 01 Mar 2009 15:26:33 +0100
Subject: [U-Boot] [PATCH 6/7 v2] OMAP3: Add OMAP3 core changes for MUSB
In-Reply-To: <49A58234.2060500@googlemail.com>
References: <1234464946-20400-1-git-send-email-dirk.behme@googlemail.com>
	<1234464946-20400-2-git-send-email-dirk.behme@googlemail.com>
	<1234464946-20400-3-git-send-email-dirk.behme@googlemail.com>
	<1234464946-20400-4-git-send-email-dirk.behme@googlemail.com>
	<1234464946-20400-5-git-send-email-dirk.behme@googlemail.com>
	<1234464946-20400-6-git-send-email-dirk.behme@googlemail.com>
	<1234464946-20400-7-git-send-email-dirk.behme@googlemail.com>
	<20090222155940.GD9867@game.jcrosoft.org>
	<49A17BCD.1030803@googlemail.com>
	<6ed0b2680902230413o33f98059q7239cbba0114c2b3@mail.gmail.com>
	<49A296F0.4000509@gmail.com>
	<20090223213636.8E526832E43F@gemini.denx.de>
	<49A427D1.6050700@googlemail.com>
	<20090224212244.183AD832E43F@gemini.denx.de>
	<49A58234.2060500@googlemail.com>
Message-ID: <49AA9B19.6060907@googlemail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dirk Behme wrote:
> Wolfgang Denk wrote:
...
>>> Other point of view of "enabling clock only if need" can be "enable 
>>> clock only if code is compiled into uboot _and_ is accessed (e.g. by 
>>> serial output over USB)" (i.e. runtime enable). I think this what 
>>
>> Yes, that is the intention.
> 
> Will it get an ACK if we change
> 
> --- u-boot-main.orig/cpu/arm_cortexa8/omap3/clock.c
> +++ u-boot-main/cpu/arm_cortexa8/omap3/clock.c
> @@ -377,5 +377,10 @@ void per_clocks_enable(void)
>       sr32(&prcm_base->fclken_per, 0, 32, FCK_PER_ON);
>       sr32(&prcm_base->iclken_per, 0, 32, ICK_PER_ON);
> 
> +#ifdef CONFIG_MUSB
> +    /* Enable the MUSB interface clock */
> +    sr32(&prcm_base->iclken1_core, 4, 1, 0x1);
> +#endif
> 
> to something like
> 
> +++ u-boot-main/cpu/arm_cortexa8/omap3/clock.c
> #ifdef CONFIG_MUSB
> void enable_musb_clock(void) {
>     sr32(&prcm_base->iclken1_core, 4, 1, 0x1);
> }
> 
> void disable_musb_clock(void) {
>     sr32(&prcm_base->iclken1_core, 4, 1, 0x0);
> }
> #endif
> 
> and then call enable/disable from MUSB code at appropriate places?

Any hint if changing the patch doing something like above as proposed 
some days ago [1] would get an ack?

Thanks

Dirk

[1] http://lists.denx.de/pipermail/u-boot/2009-February/048482.html