public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] at91: Support for the at91sam9g20 : Atmel 400Mhz ARM 926ej-s SOC.
Date: Mon, 09 Mar 2009 10:07:53 -0700	[thread overview]
Message-ID: <49B54CE9.7090006@gmail.com> (raw)
In-Reply-To: <49B51F04.8000804@atmel.com>

Hi Nicolas,

Nicolas Ferre wrote:
<snip>
> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> index af0409b..6de0a04 100644
> --- a/drivers/net/macb.c
> +++ b/drivers/net/macb.c
> @@ -447,14 +447,14 @@ static int macb_init(struct eth_device *netdev, bd_t *bd)
>  	/* choose RMII or MII mode. This depends on the board */
>  #ifdef CONFIG_RMII
>  #if defined(CONFIG_AT91CAP9) || defined(CONFIG_AT91SAM9260) || \
> -    defined(CONFIG_AT91SAM9263)
> +    defined(CONFIG_AT91SAM9263) || defined(CONFIG_AT91SAM9G20)
>  	macb_writel(macb, USRIO, MACB_BIT(RMII) | MACB_BIT(CLKEN));
>  #else
>  	macb_writel(macb, USRIO, 0);
>  #endif
>  #else
>  #if defined(CONFIG_AT91CAP9) || defined(CONFIG_AT91SAM9260) || \
> -    defined(CONFIG_AT91SAM9263)
> +    defined(CONFIG_AT91SAM9263) || defined(CONFIG_AT91SAM9G20)
>  	macb_writel(macb, USRIO, MACB_BIT(CLKEN));
>  #else
>  	macb_writel(macb, USRIO, MACB_BIT(MII));
>   
Please find a more generic way of doing this.  There should be no 
board/cpu specific #ifdefs in common drivers.  While you're at it, fix 
up the existing ones.

regards,
Ben

  parent reply	other threads:[~2009-03-09 17:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-09 13:52 [U-Boot] [PATCH] at91: Support for the at91sam9g20 : Atmel 400Mhz ARM 926ej-s SOC Nicolas Ferre
2009-03-09 15:56 ` Wolfgang Denk
2009-03-10 15:04   ` Nicolas Ferre
2009-03-09 17:07 ` Ben Warren [this message]
2009-03-11 12:40   ` Nicolas Ferre
2009-03-13 11:55     ` Jean-Christophe PLAGNIOL-VILLARD
2009-03-20 11:17   ` Nicolas Ferre
  -- strict thread matches above, loose matches on Subject: below --
2009-03-10 15:11 Nicolas Ferre
2009-03-10 16:18 ` Ben Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49B54CE9.7090006@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox