From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Warren <biggerbadderben@gmail.com>
Date: Mon, 09 Mar 2009 10:07:53 -0700
Subject: [U-Boot] [PATCH] at91: Support for the at91sam9g20 : Atmel
 400Mhz ARM 926ej-s SOC.
In-Reply-To: <49B51F04.8000804@atmel.com>
References: <49B51F04.8000804@atmel.com>
Message-ID: <49B54CE9.7090006@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Nicolas,

Nicolas Ferre wrote:
<snip>
> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> index af0409b..6de0a04 100644
> --- a/drivers/net/macb.c
> +++ b/drivers/net/macb.c
> @@ -447,14 +447,14 @@ static int macb_init(struct eth_device *netdev, bd_t *bd)
>  	/* choose RMII or MII mode. This depends on the board */
>  #ifdef CONFIG_RMII
>  #if defined(CONFIG_AT91CAP9) || defined(CONFIG_AT91SAM9260) || \
> -    defined(CONFIG_AT91SAM9263)
> +    defined(CONFIG_AT91SAM9263) || defined(CONFIG_AT91SAM9G20)
>  	macb_writel(macb, USRIO, MACB_BIT(RMII) | MACB_BIT(CLKEN));
>  #else
>  	macb_writel(macb, USRIO, 0);
>  #endif
>  #else
>  #if defined(CONFIG_AT91CAP9) || defined(CONFIG_AT91SAM9260) || \
> -    defined(CONFIG_AT91SAM9263)
> +    defined(CONFIG_AT91SAM9263) || defined(CONFIG_AT91SAM9G20)
>  	macb_writel(macb, USRIO, MACB_BIT(CLKEN));
>  #else
>  	macb_writel(macb, USRIO, MACB_BIT(MII));
>   
Please find a more generic way of doing this.  There should be no 
board/cpu specific #ifdefs in common drivers.  While you're at it, fix 
up the existing ones.

regards,
Ben