From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] 83xx: correctly set encryption and I2C bus 0 clock
Date: Wed, 11 Mar 2009 09:33:04 +0100 [thread overview]
Message-ID: <49B77740.7010400@denx.de> (raw)
In-Reply-To: <49B767DC.7020205@aimvalley.nl>
Hello Norbert,
added Kim Phillips to cc as he is the 83xx maintainer
Norbert van Bolhuis wrote:
> This patch makes sure the correct mask is applied when setting
> the encryption and I2C bus 0 clock in SCCR.
> Failing to do so may lead to ENCCM being 0 in which case I2C bus 0
> won't function.
>
>
> --- cpu/mpc83xx/cpu_init.c.org 2009-03-11 07:56:57.000000000 +0100
> +++ cpu/mpc83xx/cpu_init.c 2009-03-11 07:57:37.000000000 +0100
> @@ -106,7 +106,7 @@ void cpu_init_f (volatile immap_t * im)
> #ifdef CONFIG_SYS_SCCR_ENCCM
> /* Encryption clock mode */
> im->clk.sccr = (im->clk.sccr & ~SCCR_ENCCM) |
> - (CONFIG_SYS_SCCR_ENCCM << SCCR_PCICM_SHIFT);
> + (CONFIG_SYS_SCCR_ENCCM << SCCR_ENCCM_SHIFT);
> #endif
>
> #ifdef CONFIG_SYS_SCCR_PCICM
>
>
> Signed-off-by: Norbert van Bolhuis <nvbolhuis@aimvalley.nl>
>
Can you please use git-format-patch for making a patch?
Otherwise your patch seems okay to me,
thanks
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2009-03-11 8:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-11 7:27 [U-Boot] [PATCH] 83xx: correctly set encryption and I2C bus 0 clock Norbert van Bolhuis
2009-03-11 8:33 ` Heiko Schocher [this message]
2009-03-11 17:57 ` Kim Phillips
2009-03-11 18:22 ` Scott Wood
2009-03-11 20:05 ` Kim Phillips
2009-03-12 6:57 ` Norbert van Bolhuis
2009-03-12 10:06 ` Wolfgang Denk
2009-03-13 7:58 ` Norbert van Bolhuis
2009-03-14 23:01 ` Kim Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B77740.7010400@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox