public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] Fix for NFS boot for OMAP3 EVM
Date: Wed, 11 Mar 2009 10:39:55 -0700	[thread overview]
Message-ID: <49B7F76B.8090902@gmail.com> (raw)
In-Reply-To: <1236051571-17712-1-git-send-email-mani.pillai@ti.com>

Manikandan,

There's a disconnect between your title and what this patch does.  I 
have no reason to doubt that this fixes NFS boot on your board, BTW.
Manikandan Pillai wrote:
> The eth_halt() function has been modified to remove the
> chip reset and instead stop the transmit/receive from the device.
>
> Signed-off-by: Manikandan Pillai <mani.pillai@ti.com>
> ---
>  drivers/net/smc911x.c |   23 ++++++++++++++++++++++-
>  1 files changed, 22 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c
> index 1ded8f0..2f0852e 100644
> --- a/drivers/net/smc911x.c
> +++ b/drivers/net/smc911x.c
> @@ -116,6 +116,27 @@ static int smc911x_phy_reset(void)
>  	return 0;
>  }
>  
> +static void smc911x_shutdown(void)
> +{
> +	unsigned cr;
>   
unsigned int, please
> +
> +	/* Turn of Rx and TX */
> +	cr = smc911x_get_mac_csr(MAC_CR);
> +	cr &= ~(MAC_CR_TXEN | MAC_CR_RXEN | MAC_CR_HBDIS);
> +	smc911x_set_mac_csr(MAC_CR, cr);
> +
> +	/* Stop Transmission */
> +	cr = smc911x_get_mac_csr(TX_CFG);
> +	cr &= ~(TX_CFG_STOP_TX);
> +	smc911x_set_mac_csr(TX_CFG, cr);
> +	/* Stop receiving packets */
> +	cr = smc911x_get_mac_csr(RX_CFG);
> +	cr &= ~(RX_CFG_RXDOFF);
> +	smc911x_set_mac_csr(RX_CFG, cr);
> +
> +}
> +
> +
>  static void smc911x_phy_configure(void)
>  {
>  	int timeout;
> @@ -224,7 +245,7 @@ int eth_send(volatile void *packet, int length)
>  
>  void eth_halt(void)
>  {
> -	smc911x_reset();
> +	smc911x_shutdown();
>  }
>  
>  int eth_rx(void)
>   
Other than that, no issues.

regards,
Ben

  parent reply	other threads:[~2009-03-11 17:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-03  3:39 [U-Boot] [PATCH 1/1] Fix for NFS boot for OMAP3 EVM Manikandan Pillai
2009-03-11 14:41 ` Jean-Christophe PLAGNIOL-VILLARD
2009-03-11 17:39 ` Ben Warren [this message]
2009-04-07  5:34 ` Pillai, Manikandan
2009-04-07  6:07   ` Ben Warren
2009-04-07  6:22     ` Pillai, Manikandan
2009-04-07 13:47       ` Ben Warren
2009-04-07 15:49       ` Dirk Behme

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49B7F76B.8090902@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox