[U-Boot] [PATCH 1/1] Fix for NFS boot for OMAP3 EVM

[U-Boot] [PATCH 1/1] Fix for NFS boot for OMAP3 EVM

[Manikandan Pillai]

The eth_halt() function has been modified to remove the
chip reset and instead stop the transmit/receive from the device.

Signed-off-by: Manikandan Pillai <mani.pillai@ti.com>
---
 drivers/net/smc911x.c |   23 ++++++++++++++++++++++-
 1 files changed, 22 insertions(+), 1 deletions(-)

diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c
index 1ded8f0..2f0852e 100644
--- a/drivers/net/smc911x.c
+++ b/drivers/net/smc911x.c
@@ -116,6 +116,27 @@ static int smc911x_phy_reset(void)
 	return 0;
 }
 
+static void smc911x_shutdown(void)
+{
+	unsigned cr;
+
+	/* Turn of Rx and TX */
+	cr = smc911x_get_mac_csr(MAC_CR);
+	cr &= ~(MAC_CR_TXEN | MAC_CR_RXEN | MAC_CR_HBDIS);
+	smc911x_set_mac_csr(MAC_CR, cr);
+
+	/* Stop Transmission */
+	cr = smc911x_get_mac_csr(TX_CFG);
+	cr &= ~(TX_CFG_STOP_TX);
+	smc911x_set_mac_csr(TX_CFG, cr);
+	/* Stop receiving packets */
+	cr = smc911x_get_mac_csr(RX_CFG);
+	cr &= ~(RX_CFG_RXDOFF);
+	smc911x_set_mac_csr(RX_CFG, cr);
+
+}
+
+
 static void smc911x_phy_configure(void)
 {
 	int timeout;
@@ -224,7 +245,7 @@ int eth_send(volatile void *packet, int length)
 
 void eth_halt(void)
 {
-	smc911x_reset();
+	smc911x_shutdown();
 }
 
 int eth_rx(void)
-- 
1.5.6

[U-Boot] [PATCH 1/1] Fix for NFS boot for OMAP3 EVM

[Jean-Christophe PLAGNIOL-VILLARD]

On 09:09 Tue 03 Mar     , Manikandan Pillai wrote:
> The eth_halt() function has been modified to remove the
> chip reset and instead stop the transmit/receive from the device.
it's not really a fix of the OMAP3 please use a better commit message

Ben could you take a look

Best Regards,
J.

[U-Boot] [PATCH 1/1] Fix for NFS boot for OMAP3 EVM

[Ben Warren]

Manikandan,

There's a disconnect between your title and what this patch does.  I 
have no reason to doubt that this fixes NFS boot on your board, BTW.
Manikandan Pillai wrote:
> The eth_halt() function has been modified to remove the
> chip reset and instead stop the transmit/receive from the device.
>
> Signed-off-by: Manikandan Pillai <mani.pillai@ti.com>
> ---
>  drivers/net/smc911x.c |   23 ++++++++++++++++++++++-
>  1 files changed, 22 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c
> index 1ded8f0..2f0852e 100644
> --- a/drivers/net/smc911x.c
> +++ b/drivers/net/smc911x.c
> @@ -116,6 +116,27 @@ static int smc911x_phy_reset(void)
>  	return 0;
>  }
>  
> +static void smc911x_shutdown(void)
> +{
> +	unsigned cr;
>   
unsigned int, please
> +
> +	/* Turn of Rx and TX */
> +	cr = smc911x_get_mac_csr(MAC_CR);
> +	cr &= ~(MAC_CR_TXEN | MAC_CR_RXEN | MAC_CR_HBDIS);
> +	smc911x_set_mac_csr(MAC_CR, cr);
> +
> +	/* Stop Transmission */
> +	cr = smc911x_get_mac_csr(TX_CFG);
> +	cr &= ~(TX_CFG_STOP_TX);
> +	smc911x_set_mac_csr(TX_CFG, cr);
> +	/* Stop receiving packets */
> +	cr = smc911x_get_mac_csr(RX_CFG);
> +	cr &= ~(RX_CFG_RXDOFF);
> +	smc911x_set_mac_csr(RX_CFG, cr);
> +
> +}
> +
> +
>  static void smc911x_phy_configure(void)
>  {
>  	int timeout;
> @@ -224,7 +245,7 @@ int eth_send(volatile void *packet, int length)
>  
>  void eth_halt(void)
>  {
> -	smc911x_reset();
> +	smc911x_shutdown();
>  }
>  
>  int eth_rx(void)
>   
Other than that, no issues.

regards,
Ben

[U-Boot] [PATCH 1/1] Fix for NFS boot for OMAP3 EVM

[Pillai, Manikandan]

Hi,

What is the status of this patch ?
Any comments.

regards

> -----Original Message-----
> From: Pillai, Manikandan
> Sent: Tuesday, March 03, 2009 9:10 AM
> To: u-boot at lists.denx.de; dirk.behme at googlemail.com
> Cc: Pillai, Manikandan
> Subject: [PATCH 1/1] Fix for NFS boot for OMAP3 EVM
> 
> The eth_halt() function has been modified to remove the
> chip reset and instead stop the transmit/receive from the device.
> 
> Signed-off-by: Manikandan Pillai <mani.pillai@ti.com>
> ---
>  drivers/net/smc911x.c |   23 ++++++++++++++++++++++-
>  1 files changed, 22 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c
> index 1ded8f0..2f0852e 100644
> --- a/drivers/net/smc911x.c
> +++ b/drivers/net/smc911x.c
> @@ -116,6 +116,27 @@ static int smc911x_phy_reset(void)
>  	return 0;
>  }
> 
> +static void smc911x_shutdown(void)
> +{
> +	unsigned cr;
> +
> +	/* Turn of Rx and TX */
> +	cr = smc911x_get_mac_csr(MAC_CR);
> +	cr &= ~(MAC_CR_TXEN | MAC_CR_RXEN | MAC_CR_HBDIS);
> +	smc911x_set_mac_csr(MAC_CR, cr);
> +
> +	/* Stop Transmission */
> +	cr = smc911x_get_mac_csr(TX_CFG);
> +	cr &= ~(TX_CFG_STOP_TX);
> +	smc911x_set_mac_csr(TX_CFG, cr);
> +	/* Stop receiving packets */
> +	cr = smc911x_get_mac_csr(RX_CFG);
> +	cr &= ~(RX_CFG_RXDOFF);
> +	smc911x_set_mac_csr(RX_CFG, cr);
> +
> +}
> +
> +
>  static void smc911x_phy_configure(void)
>  {
>  	int timeout;
> @@ -224,7 +245,7 @@ int eth_send(volatile void *packet, int length)
> 
>  void eth_halt(void)
>  {
> -	smc911x_reset();
> +	smc911x_shutdown();
>  }
> 
>  int eth_rx(void)
> --
> 1.5.6

[U-Boot] [PATCH 1/1] Fix for NFS boot for OMAP3 EVM

[Ben Warren]

On Mon, Apr 6, 2009 at 10:34 PM, Pillai, Manikandan <mani.pillai@ti.com>wrote:

>
> Hi,
>
> What is the status of this patch ?
> Any comments.
>
Did you fix the things I mentioned and re-submit?

regards,
Ben

[U-Boot] [PATCH 1/1] Fix for NFS boot for OMAP3 EVM

[Pillai, Manikandan]

Hi Ben,

I believe your comments were on the timeout setting of 1ms for u-boot timer.
I am not sure whether I received any comments from you on the NFS boot patch.

Regards
Mani

________________________________
From: Ben Warren [mailto:biggerbadderben at gmail.com]
Sent: Tuesday, April 07, 2009 11:38 AM
To: Pillai, Manikandan
Cc: u-boot at lists.denx.de; dirk.behme at googlemail.com
Subject: Re: [U-Boot] [PATCH 1/1] Fix for NFS boot for OMAP3 EVM


On Mon, Apr 6, 2009 at 10:34 PM, Pillai, Manikandan <mani.pillai at ti.com<mailto:mani.pillai@ti.com>> wrote:

Hi,

What is the status of this patch ?
Any comments.
Did you fix the things I mentioned and re-submit?

regards,
Ben

[U-Boot] [PATCH 1/1] Fix for NFS boot for OMAP3 EVM

[Ben Warren]

On Mon, Apr 6, 2009 at 11:22 PM, Pillai, Manikandan <mani.pillai@ti.com>wrote:

>  Hi Ben,
>
>
>
> I believe your comments were on the timeout setting of 1ms for u-boot
> timer.
>
> I am not sure whether I received any comments from you on the NFS boot
> patch.
>
>
>
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/55784/

Please don't top-post.

regards,
Ben

> Regards
>
> Mani
>
>
>   ------------------------------
>
> *From:* Ben Warren [mailto:biggerbadderben at gmail.com]
> *Sent:* Tuesday, April 07, 2009 11:38 AM
> *To:* Pillai, Manikandan
> *Cc:* u-boot at lists.denx.de; dirk.behme at googlemail.com
> *Subject:* Re: [U-Boot] [PATCH 1/1] Fix for NFS boot for OMAP3 EVM
>
>
>
>
>
> On Mon, Apr 6, 2009 at 10:34 PM, Pillai, Manikandan <mani.pillai@ti.com>
> wrote:
>
>
> Hi,
>
> What is the status of this patch ?
> Any comments.
>
> Did you fix the things I mentioned and re-submit?
>
>
>
> regards,
>
> Ben
>

[U-Boot] [PATCH 1/1] Fix for NFS boot for OMAP3 EVM

[Dirk Behme]

Hi Mani,

Pillai, Manikandan wrote:
> Hi Ben,
> 
> I believe your comments were on the timeout setting of 1ms for u-boot timer.
> I am not sure whether I received any comments from you on the NFS boot patch.

Looking at [1] and [2], it seems to me that they want

- a better patch subject which matches what the patch does
- an unsigned int

Best regards

Dirk

[1] http://lists.denx.de/pipermail/u-boot/2009-March/048889.html

[2] http://lists.denx.de/pipermail/u-boot/2009-March/048899.html

> ________________________________
> From: Ben Warren [mailto:biggerbadderben at gmail.com]
> Sent: Tuesday, April 07, 2009 11:38 AM
> To: Pillai, Manikandan
> Cc: u-boot at lists.denx.de; dirk.behme at googlemail.com
> Subject: Re: [U-Boot] [PATCH 1/1] Fix for NFS boot for OMAP3 EVM
> 
> 
> On Mon, Apr 6, 2009 at 10:34 PM, Pillai, Manikandan <mani.pillai at ti.com<mailto:mani.pillai@ti.com>> wrote:
> 
> Hi,
> 
> What is the status of this patch ?
> Any comments.
> Did you fix the things I mentioned and re-submit?
> 
> regards,
> Ben
>