public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] powerpc: common updates for keymile boards
Date: Wed, 11 Mar 2009 19:38:15 +0100	[thread overview]
Message-ID: <49B80517.6080108@denx.de> (raw)
In-Reply-To: <20090311130117.fe8719c1.kim.phillips@freescale.com>

Hello Kim,

Kim Phillips wrote:
> On Wed, 11 Mar 2009 09:04:39 +0100
> Heiko Schocher <hs@denx.de> wrote:
> 
>> - added to keymile-common.h:
>>   - bootcount support for kmeter1
> 
> I don't see this.

diff --git a/include/configs/keymile-common.h b/include/configs/keymile-common.h
index c7f6ba3..f1bcb46 100644
--- a/include/configs/keymile-common.h
+++ b/include/configs/keymile-common.h
@@ -27,9 +27,7 @@
 /* Do boardspecific init for all boards */
 #define CONFIG_BOARD_EARLY_INIT_R       1

-#if defined(CONFIG_MGCOGE) || defined(CONFIG_MGSUVD)
 #define CONFIG_BOOTCOUNT_LIMIT
-#endif

 /*
  * Command line configuration.

with deleting the "-#if defined(CONFIG_MGCOGE) || defined(CONFIG_MGSUVD)"
line it is also activated for the kmeter1

>> diff --git a/include/configs/kmeter1.h b/include/configs/kmeter1.h
>> index 49a801f..f7fc6c5 100644
>> --- a/include/configs/kmeter1.h
>> +++ b/include/configs/kmeter1.h
>> @@ -33,6 +33,7 @@
>>  /* include common defines/options for all Keymile boards */
>>  #include "keymile-common.h"
>>
>> +#undef CONFIG_SYS_I2C_INIT_BOARD
> 
> personally, I'd favour setting this in the individual board configs,
> rather than #defining and then #undefing it in the less common
> case.  But they're your boards, and thus ultimately your call.

The "#undef CONFIG_SYS_I2C_INIT_BOARD" will go away in the next
release after 2009.03 (hopefully) so it is again a common option
for all keymile boards. But because it is a new feature for fsl_i2c
I post it in the next merge window.

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2009-03-11 18:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-11  8:04 [U-Boot] [PATCH 1/3] powerpc: common updates for keymile boards Heiko Schocher
2009-03-11 18:01 ` Kim Phillips
2009-03-11 18:38   ` Heiko Schocher [this message]
2009-03-11 19:59     ` Kim Phillips

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49B80517.6080108@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox