public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mark Jackson <mpfj-list@mimc.co.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] Fix JFFS2 NOR sector size routine
Date: Thu, 12 Mar 2009 09:12:54 +0000	[thread overview]
Message-ID: <49B8D216.8060301@mimc.co.uk> (raw)
In-Reply-To: <20090311182929.GB17613@ld0162-tx32.am.freescale.net>

On 11/03/09 18:29, Scott Wood wrote:
> On Wed, Mar 11, 2009 at 09:54:20AM +0000, Mark Jackson wrote:
>> diff --git a/common/cmd_jffs2.c b/common/cmd_jffs2.c
>> index d0a7cea..2f3b3a9 100644
>> --- a/common/cmd_jffs2.c
>> +++ b/common/cmd_jffs2.c
>> @@ -1814,7 +1814,12 @@ static inline u32 get_part_sector_size_nor(struct
>> mtdids *id, struct part_info *
>>    	flash =&flash_info[id->num];
>>
>>    	start_phys = flash->start[0] + part->offset;
>> -	end_phys = start_phys + part->size;
>> +
>> +	if (part->size == SIZE_REMAINING) {
>> +		end_phys = start_phys + flash->size;
>> +	} else {
>> +		end_phys = start_phys + part->size;
>> +	}
>
> That looks wrong if part->offset != 0; shouldn't it be:
>
> if (part->size == SIZE_REMAINING)
> 	end_phys = flash->start[0] + flash->size;
> else
> 	end_phys = start_phys + part->size;
>
> ?
>
> -Scott

Yes ... that seems perfectly reasonable !!

I'll update my patch, retest and resubmit.

Thanks
Mark

      reply	other threads:[~2009-03-12  9:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-11  9:54 [U-Boot] [PATCH 1/1] Fix JFFS2 NOR sector size routine Mark Jackson
2009-03-11 18:29 ` Scott Wood
2009-03-12  9:12   ` Mark Jackson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49B8D216.8060301@mimc.co.uk \
    --to=mpfj-list@mimc.co.uk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox