public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Grzegorz Bernacki <gjb@semihalf.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6] Add support for the digsy MTC board.
Date: Thu, 12 Mar 2009 16:25:08 +0100	[thread overview]
Message-ID: <49B92954.2080504@semihalf.com> (raw)
In-Reply-To: <20090312125601.96527832E8B8@gemini.denx.de>

Wolfgang Denk wrote:
>> +	for (n = 0; n < 6 ; n++) {
>> +		addr = addr_of_eth_addr + n;
>> +		chip = EEPROM_ADDR + ((addr & 0x300)>>8);
>> +		i2c_read(chip, (addr & 0xFF), 1, (uchar *)&eth_addr[n], 1);
>> +	}
> 
> Can we not do this with a single i2c_read() call with length = 6 ?
> 

Yes we can, but it is safer this way in the case when ethernet address
spans across two chips. Rest of comments addressed in version 7 of the
patch which will be sent soon.

regards,
Grzesiek

  reply	other threads:[~2009-03-12 15:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-13 13:53 [U-Boot] [PATCH v6] Add support for the digsy MTC board Grzegorz Bernacki
2009-02-19 11:21 ` Grzegorz Bernacki
2009-03-12 12:56 ` Wolfgang Denk
2009-03-12 15:25   ` Grzegorz Bernacki [this message]
2009-03-12 18:47     ` Wolfgang Denk
2009-03-13  9:49       ` Grzegorz Bernacki
2009-03-13 13:47         ` Wolfgang Denk
2009-03-17  9:05           ` Grzegorz Bernacki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49B92954.2080504@semihalf.com \
    --to=gjb@semihalf.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox