From mboxrd@z Thu Jan  1 00:00:00 1970
From: Grzegorz Bernacki <gjb@semihalf.com>
Date: Thu, 12 Mar 2009 16:25:08 +0100
Subject: [U-Boot] [PATCH v6] Add support for the digsy MTC board.
In-Reply-To: <20090312125601.96527832E8B8@gemini.denx.de>
References: <12345332203460-git-send-email-gjb@semihalf.com>
	<20090312125601.96527832E8B8@gemini.denx.de>
Message-ID: <49B92954.2080504@semihalf.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Wolfgang Denk wrote:
>> +	for (n = 0; n < 6 ; n++) {
>> +		addr = addr_of_eth_addr + n;
>> +		chip = EEPROM_ADDR + ((addr & 0x300)>>8);
>> +		i2c_read(chip, (addr & 0xFF), 1, (uchar *)&eth_addr[n], 1);
>> +	}
> 
> Can we not do this with a single i2c_read() call with length = 6 ?
> 

Yes we can, but it is safer this way in the case when ethernet address
spans across two chips. Rest of comments addressed in version 7 of the
patch which will be sent soon.

regards,
Grzesiek