public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jerry Van Baren <gerald.vanbaren@ge.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add bank configuration to FSL spd_sdram.c
Date: Fri, 13 Mar 2009 08:03:26 -0400	[thread overview]
Message-ID: <49BA4B8E.9080608@ge.com> (raw)
In-Reply-To: <D7CCA83BB0796C49BC0BB53B6AB1208916D3B1@zch01exm21.fsl.freescale.net>

Liu Dave-R63238 wrote:
>> The routine assumed 4 bank SDRAMs, enhance to configure for 4 
>> or 8 bank SDRAMs.
>>
>> Signed-off-by: Gerald Van Baren <vanbaren@cideas.com>
>> ---
>>
>> I haven't made much headway on adapting the cpu/mpc8xxxx/ddr 
>> routines to the 83xx (8360).  It has some 85xx (86xx) 
>> assumptions in that needs to be pulled out.
>>
>> Meanwhile, the cpu/mpc83xx/spd_sdram.c routine /almost/ worked for me.
>> It turns out my DIMM stick has 8 banks which was being 
>> ignored (hard-coded for 4 banks).  The enhancement below 
>> fixed that for me.
>>
>> It would be Really Good to get this verified and in the 
>> pending release.
> 
> Could you also make the same change to #CS2# and #CS3?
> 
> Thanks, Dave

AAARGH, will do.

Sorry,
gvb

  reply	other threads:[~2009-03-13 12:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-13  4:05 [U-Boot] [PATCH] Add bank configuration to FSL spd_sdram.c Jerry Van Baren
2009-03-13  4:19 ` Liu Dave-R63238
2009-03-13 12:03   ` Jerry Van Baren [this message]
2009-03-13 15:40 ` [U-Boot] [PATCH v2] " Jerry Van Baren
2009-03-14  0:59   ` Liu Dave-R63238
2009-03-14 23:02     ` Kim Phillips

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49BA4B8E.9080608@ge.com \
    --to=gerald.vanbaren@ge.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox