* [U-Boot] [PATCH to 2008.03] net: sh_eth: Remove sh_eth_reset() from halt function
@ 2009-03-18 3:27 Nobuhiro Iwamatsu
2009-03-20 8:33 ` Nobuhiro Iwamatsu
2009-03-20 21:16 ` Wolfgang Denk
0 siblings, 2 replies; 4+ messages in thread
From: Nobuhiro Iwamatsu @ 2009-03-18 3:27 UTC (permalink / raw)
To: u-boot
sh_eth_reset is function to reset Ether IP.
The MAC address is stored in IP, but it is initialized by this function.
OS (e.g. Linux Kernel) can not use this device when initialized.
This revises this problem.
Signed-off-by: Nobuhiro Iwamatsu <iwamatsu.nobuhiro@renesas.com>
---
drivers/net/sh_eth.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/sh_eth.c b/drivers/net/sh_eth.c
index ebe8588..bee3f02 100644
--- a/drivers/net/sh_eth.c
+++ b/drivers/net/sh_eth.c
@@ -639,8 +639,6 @@ err:
void sh_eth_halt(struct eth_device *dev)
{
struct sh_eth_dev *eth = dev->priv;
-
- sh_eth_reset(eth);
sh_eth_stop(eth);
}
--
1.6.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH to 2008.03] net: sh_eth: Remove sh_eth_reset() from halt function
2009-03-18 3:27 [U-Boot] [PATCH to 2008.03] net: sh_eth: Remove sh_eth_reset() from halt function Nobuhiro Iwamatsu
@ 2009-03-20 8:33 ` Nobuhiro Iwamatsu
2009-03-20 21:17 ` Wolfgang Denk
2009-03-20 21:16 ` Wolfgang Denk
1 sibling, 1 reply; 4+ messages in thread
From: Nobuhiro Iwamatsu @ 2009-03-20 8:33 UTC (permalink / raw)
To: u-boot
Hi,
Sorry,
Please take this patch in 2009.03 not 2008.03.
Best regards,
Nobuhiro
On Wed, 18 Mar 2009 12:27:04 +0900
Nobuhiro Iwamatsu <iwamatsu.nobuhiro@renesas.com> wrote:
> sh_eth_reset is function to reset Ether IP.
> The MAC address is stored in IP, but it is initialized by this function.
> OS (e.g. Linux Kernel) can not use this device when initialized.
> This revises this problem.
>
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu.nobuhiro@renesas.com>
> ---
> drivers/net/sh_eth.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/sh_eth.c b/drivers/net/sh_eth.c
> index ebe8588..bee3f02 100644
> --- a/drivers/net/sh_eth.c
> +++ b/drivers/net/sh_eth.c
> @@ -639,8 +639,6 @@ err:
> void sh_eth_halt(struct eth_device *dev)
> {
> struct sh_eth_dev *eth = dev->priv;
> -
> - sh_eth_reset(eth);
> sh_eth_stop(eth);
> }
>
> --
> 1.6.2
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
--
Nobuhiro Iwamatsu
hemamu at t-base.ne.jp
iwamatsu at debian.or.jp
GPG ID : 3170EBE9
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH to 2008.03] net: sh_eth: Remove sh_eth_reset() from halt function
2009-03-20 8:33 ` Nobuhiro Iwamatsu
@ 2009-03-20 21:17 ` Wolfgang Denk
0 siblings, 0 replies; 4+ messages in thread
From: Wolfgang Denk @ 2009-03-20 21:17 UTC (permalink / raw)
To: u-boot
Dear Nobuhiro Iwamatsu,
In message <20090320173324.3c9d6040.iwamatsu@nigauri.org> you wrote:
>
> Sorry,
> Please take this patch in 2009.03 not 2008.03.
Done, thanks for pointing out.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There are three things I always forget. Names, faces - the third I
can't remember. - Italo Svevo
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH to 2008.03] net: sh_eth: Remove sh_eth_reset() from halt function
2009-03-18 3:27 [U-Boot] [PATCH to 2008.03] net: sh_eth: Remove sh_eth_reset() from halt function Nobuhiro Iwamatsu
2009-03-20 8:33 ` Nobuhiro Iwamatsu
@ 2009-03-20 21:16 ` Wolfgang Denk
1 sibling, 0 replies; 4+ messages in thread
From: Wolfgang Denk @ 2009-03-20 21:16 UTC (permalink / raw)
To: u-boot
Dear Nobuhiro Iwamatsu,
In message <49C06A08.8040509@renesas.com> you wrote:
> sh_eth_reset is function to reset Ether IP.
> The MAC address is stored in IP, but it is initialized by this function.
> OS (e.g. Linux Kernel) can not use this device when initialized.
> This revises this problem.
>
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu.nobuhiro@renesas.com>
> ---
> drivers/net/sh_eth.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Can you imagine how life could be improved if we could do away with
jealousy, greed, hate ..."
"It can also be improved by eliminating love, tenderness, sentiment
-- the other side of the coin"
-- Dr. Roger Corby and Kirk, "What are Little Girls Made Of?",
stardate 2712.4
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-03-20 21:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-18 3:27 [U-Boot] [PATCH to 2008.03] net: sh_eth: Remove sh_eth_reset() from halt function Nobuhiro Iwamatsu
2009-03-20 8:33 ` Nobuhiro Iwamatsu
2009-03-20 21:17 ` Wolfgang Denk
2009-03-20 21:16 ` Wolfgang Denk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox