public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] video: mx3fb: board specific settings?
@ 2009-03-23 15:01 Jens Gehrlein
  0 siblings, 0 replies; only message in thread
From: Jens Gehrlein @ 2009-03-23 15:01 UTC (permalink / raw)
  To: u-boot

Hi,

currently drivers/video/mx3fb.c contains some defines, which are
usually board specific:
#define XRES		240
#define YRES		320
#define PANEL_TYPE	IPU_PANEL_TFT
#define PIXEL_CLK	185925
#define PIXEL_FMT	IPU_PIX_FMT_RGB666
#define H_START_WIDTH	9		/* left_margin */
#define H_SYNC_WIDTH	1		/* hsync_len */
#define H_END_WIDTH	(16 + 1)	/* right_margin + hsync_len */
#define V_START_WIDTH	7		/* upper_margin */
#define V_SYNC_WIDTH	1		/* vsync_len */
#define V_END_WIDTH	(9 + 1)		/* lower_margin + vsync_len */
#define SIG_POL		(DI_D3_DRDY_SHARP_POL | DI_D3_CLK_POL)
#define IF_CONF		0
#define IF_CLK_DIV	0x175

What could be done to remove these defines?
1. #ifdefery -> seems to be the worst solution
2. a structure, filled by board code
3. any other ideas?

What has to be done else? For instance, parts of lcd_enable()
seem to be board specific, too (pin muxing, display brightness, ...).

Thanks.

Kind regards,
Jens

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-03-23 15:01 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-23 15:01 [U-Boot] video: mx3fb: board specific settings? Jens Gehrlein

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox