From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Tue, 24 Mar 2009 09:38:04 +0100 Subject: [U-Boot] [PATCH 1/3] mpc5200: do not use printf in i2c_init() In-Reply-To: <9e4733910903221955h4a6b3c24t34cce6989911be21@mail.gmail.com> References: <20090321133727.11905.38048.stgit@localhost> <20090321133844.11905.61201.stgit@localhost> <20090321194733.68507832E406@gemini.denx.de> <9e4733910903211339u60f5531cp7a9574f2d1ba264f@mail.gmail.com> <20090321205648.95B0F832E406@gemini.denx.de> <9e4733910903220701h104932cdu6b226e5c05e9b3d4@mail.gmail.com> <20090322142101.DB34B832E406@gemini.denx.de> <9e4733910903220723u31546286q233c9b24b7a5d53@mail.gmail.com> <20090322152342.26FD8832E406@gemini.denx.de> <9e4733910903221955h4a6b3c24t34cce6989911be21@mail.gmail.com> Message-ID: <49C89BEC.6050100@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Jon, Jon Smirl wrote: > On Sun, Mar 22, 2009 at 11:23 AM, Wolfgang Denk wrote: > >> Dear Jon Smirl, >> >> In message <9e4733910903220723u31546286q233c9b24b7a5d53@mail.gmail.com> you wrote: >> >>> Would it be better to put the check for (gd->have_console) into printf itself? >>> >> No, as you could also use puts() or putc(). There are only a few >> isolated places where we need this, so let's make this clearly >> visible there. >> > > mpc5200 with eeprom, suppress printf until console initialized > > From: Jon Smirl > > On boards which have the environment in eeprom, i2c_init() > is called before the console and ram is initialized. Suppress > printfs until the console is initialized. > > Signed-off-by: Jon Smirl > --- > cpu/mpc5xxx/i2c.c | 30 ++++++++++++++++++++---------- > 1 files changed, 20 insertions(+), 10 deletions(-) > Acked-by: Heiko Schocher bye Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany