From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] inka4x0: Add hardware diagnosis functions for inka4x0
Date: Tue, 24 Mar 2009 18:08:35 -0500 [thread overview]
Message-ID: <49C967F3.4080001@freescale.com> (raw)
In-Reply-To: <20090324225035.B28A3832E406@gemini.denx.de>
Wolfgang Denk wrote:
>> +static int do_inkadiag_serial(cmd_tbl_t *cmdtp, int flag, int argc,
>> + char *argv[]) {
>> + if (argc < 5) {
>> + cmd_usage(cmdtp);
>> + return 1;
>> + }
>> +
>> + argc--;
>> + argv++;
>> +
>> + unsigned int num = simple_strtol(argv[0], NULL, 0);
>
> Please NEVER declare variables right in the middle of the code!!
>
> Did this actually pass a compile test?
Probably -- it's been legal C for about a decade.
Style is another matter, but the compiler's not going to enforce that. :-)
-Scott
next prev parent reply other threads:[~2009-03-24 23:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-24 17:02 [U-Boot] [PATCH v1 0/7] Update for inka4x0 plus some new features Detlev Zundel
2009-03-24 17:02 ` [U-Boot] [PATCH] command.c: Expose the core of do_help as _do_help to the rest of u-boot Detlev Zundel
2009-03-24 17:02 ` [U-Boot] [PATCH] mpc5xxx: Add structure definition for several more register blocks Detlev Zundel
2009-03-24 17:02 ` [U-Boot] [PATCH] drivers/twserial: Add protocol driver for "three wire serial" interface Detlev Zundel
2009-03-24 17:02 ` [U-Boot] [PATCH] rtc: add support for 4543 RTC (manufactured by e.g. EPSON) Detlev Zundel
2009-03-24 17:02 ` [U-Boot] [PATCH] inka4x0: Add hardware diagnosis functions for inka4x0 Detlev Zundel
2009-03-24 17:02 ` [U-Boot] [PATCH] inka4x0: Add hardware diagnosis and RTC in configuration Detlev Zundel
2009-03-24 17:02 ` [U-Boot] [PATCH] inka4x0: Use proper accessor macros for memory mapped registers Detlev Zundel
2009-03-24 22:56 ` [U-Boot] [PATCH] inka4x0: Add hardware diagnosis and RTC in configuration Wolfgang Denk
2009-03-25 9:16 ` Detlev Zundel
2009-03-25 9:41 ` Wolfgang Denk
2009-03-25 15:18 ` Detlev Zundel
2009-03-24 23:47 ` Anatolij Gustschin
2009-03-24 17:53 ` [U-Boot] [PATCH] inka4x0: Add hardware diagnosis functions for inka4x0 Heiko Schocher
2009-03-24 22:38 ` Wolfgang Denk
2009-03-25 9:40 ` Detlev Zundel
2009-03-25 9:40 ` Detlev Zundel
2009-03-25 12:16 ` Heiko Schocher
2009-03-24 22:50 ` Wolfgang Denk
2009-03-24 23:08 ` Scott Wood [this message]
2009-03-25 15:07 ` Detlev Zundel
2009-03-25 19:07 ` Wolfgang Denk
2009-03-24 23:36 ` Anatolij Gustschin
2009-03-25 9:13 ` Detlev Zundel
2009-03-24 22:54 ` [U-Boot] [PATCH] drivers/twserial: Add protocol driver for "three wire serial" interface Wolfgang Denk
2009-03-25 15:49 ` Detlev Zundel
2009-03-27 20:04 ` [U-Boot] [PATCH] mpc5xxx: Add structure definition for several more register blocks Wolfgang Denk
2009-03-24 22:36 ` [U-Boot] [PATCH v1 0/7] Update for inka4x0 plus some new features Wolfgang Denk
2009-03-25 15:12 ` Detlev Zundel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C967F3.4080001@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox