From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Date: Tue, 24 Mar 2009 18:08:35 -0500
Subject: [U-Boot] [PATCH] inka4x0: Add hardware diagnosis functions for
 inka4x0
In-Reply-To: <20090324225035.B28A3832E406@gemini.denx.de>
References: <1237914158-15693-1-git-send-email-dzu@denx.de>	<1237914158-15693-2-git-send-email-dzu@denx.de>	<1237914158-15693-3-git-send-email-dzu@denx.de>	<1237914158-15693-4-git-send-email-dzu@denx.de>	<1237914158-15693-5-git-send-email-dzu@denx.de>	<1237914158-15693-6-git-send-email-dzu@denx.de>
	<20090324225035.B28A3832E406@gemini.denx.de>
Message-ID: <49C967F3.4080001@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Wolfgang Denk wrote:
>> +static int do_inkadiag_serial(cmd_tbl_t *cmdtp, int flag, int argc,
>> +			      char *argv[]) {
>> +	if (argc < 5) {
>> +		cmd_usage(cmdtp);
>> +		return 1;
>> +	}
>> +
>> +	argc--;
>> +	argv++;
>> +
>> +	unsigned int num = simple_strtol(argv[0], NULL, 0);
> 
> Please NEVER declare variables right in the middle of the code!!
> 
> Did this actually pass a compile test?

Probably -- it's been legal C for about a decade.

Style is another matter, but the compiler's not going to enforce that. :-)

-Scott