[U-Boot] [PATCH 1/2] LPC2468 support

Stefan Roese
2009-04-28T06:27:45Z

Hi Wolfgang,

On Tuesday 28 April 2009, Wolfgang Denk wrote:
> > I took a quick look at the flash "driver". The main functions
> > lpc24xx_flash_erase() and lpc24xx_write_buff() are not even referenced
> > somewhere in this patch. They seem to be used in the 2nd patch (2/2)
> > though. It's hard to really understand what's going on here. So this
> > flash driver part really needs some sort of documentation how it's
> > supposed to work.
> >
> > And I also think this driver (as all FLASH related drivers) should be
> > moved into drivers/mtd instead.
>
> Into drivers/mtd? Even if it's not a MTD driver? This doesn't make
> mnuch sense to me.

In the end this driver will be used by the common FLASH user interface
(cmd_flash.c, cmd_mem.c). So I prefer to have the "driver" for this interface
in a common place for a better overview. And the only common place I can
think of is drivers/mtd right now. We should probably add a subdirectory for
NOR flash drivers: drivers/mtd/nor (or drivers/mtd/maps as done in Linux).

BTW: This common place will prevent those multiple platform/board specific
flash drivers we have right now as well.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================