[U-Boot] [PATCH 1/2] LPC2468 support

Stefan Roese
2009-04-28T07:08:01Z

Hi Wolfgang,

On Tuesday 28 April 2009, Wolfgang Denk wrote:
> > > Into drivers/mtd? Even if it's not a MTD driver? This doesn't make
> > > mnuch sense to me.
> >
> > In the end this driver will be used by the common FLASH user interface
> > (cmd_flash.c, cmd_mem.c). So I prefer to have the "driver" for this
> > interface
>
> Yes. But MTD is a description of a specific interface. Even now we
> have two versions of the CFI driver: drivers/mtd/cfi_flash.c and
> drivers/mtd/cfi_mtd.c,

No, we don't have "two versions of the CFI driver". cfi_mtd.c is not really a
driver but "only" a wrapper implementing the MTD infrastructure on top of the
U-Boot NOR driver (cfi_flash or others).

> and if we look closer at it only cfi_mtd.c
> makes sense in this directory. cfi_flash.c is *not* MTD conformant
> and should be somewhere else.
>
> > in a common place for a better overview. And the only common place I can
> > think of is drivers/mtd right now. We should probably add a subdirectory
> > for
>
> Maybe we should create drivers/flash for those non-MTD flash drivers?
> Then we should also move cfi_flash.c there.

Yes, this could be done.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================