[U-Boot] [PATCH 1/2] LPC2468 support

Wolfgang Denk
2009-04-28T06:46:26Z

Dear Stefan Roese,

In message <200904280827.45894.sr@denx.de> you wrote:
>
> > Into drivers/mtd? Even if it's not a MTD driver? This doesn't make
> > mnuch sense to me.
>
> In the end this driver will be used by the common FLASH user interface
> (cmd_flash.c, cmd_mem.c). So I prefer to have the "driver" for this interface

Yes. But MTD is a description of a specific interface. Even now we
have two versions of the CFI driver: drivers/mtd/cfi_flash.c and
drivers/mtd/cfi_mtd.c, and if we look closer at it only cfi_mtd.c
makes sense in this directory. cfi_flash.c is *not* MTD conformant
and should be somewhere else.

> in a common place for a better overview. And the only common place I can
> think of is drivers/mtd right now. We should probably add a subdirectory for

Maybe we should create drivers/flash for those non-MTD flash drivers?
Then we should also move cfi_flash.c there.

> NOR flash drivers: drivers/mtd/nor (or drivers/mtd/maps as done in Linux).

Um... this is something different - in Linux all flash drivers (at
least all in mainline) are handled through the MTD layer.

> BTW: This common place will prevent those multiple platform/board specific
> flash drivers we have right now as well.

We agree on that.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Overflow on /dev/null, please empty the bit bucket.