public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Richard Retanubun <RichardRetanubun@RuggedCom.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Coldfire: I2C: Update I2CFDR frequency divider 0x0E value from 192 to 204
Date: Wed, 25 Mar 2009 08:50:25 -0400	[thread overview]
Message-ID: <49CA2891.3060604@RuggedCom.com> (raw)
In-Reply-To: <a90206390903241920n11c46b21i79fcf88058e7f4f6@mail.gmail.com>

Hi TC,
> Richard,
> 
> Nak.
> 
> The divider and fdr value are predefined in the 5271 reference manual.
I know, that's why I said this is empirical evidence, not mathematical :)
> 
> The bus clock is 50Mhz and the CONFIG_SYS_I2C_SPEED is set to 80000.
This is the default for the M5271EVB, yes, but I've modded mine to have the bus clock at 75 MHz, and CONFIG_SYS_I2C_SPEED set to 4000000
(bus clock 75MHz being the Max speed supported by the M5271).

What I observed is that although there are two divider value that claims to divide by 192 (namely {192, 14} and {192, 49},
my empirical experiments shows that for the setup described above, 49 (listed after 14, and never picked) results
in a closer approximation. So we have two options:

1. Reorder the table entry so that {192, 49} is listed before {192, 14} and hence picked. (this is confusing though)
2. Assign 14 to a value it is observed to divide by (div-by-204) in the setup I described above.
3. Remove the {192, 14} entry, so that {192, 49} is picked. (this does not match the documentation)

I opted for the 2nd option because having two identical divider entries and having only the first one listed picked seems redundant.

I am not claiming that the divider value that I assign from {192, 14} to {204, 14} will be true for ALL i2c controllers in all Coldfires,
that depends if the same circuit and silicon is stamped on them, I was hoping that the freescale folks can help us with that :)

Regards,

- Richard

      reply	other threads:[~2009-03-25 12:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-18 17:07 [U-Boot] [PATCH] Coldfire: I2C: Update I2CFDR frequency divider 0x0E value from 192 to 204 Richard Retanubun
2009-03-18 17:22 ` Kumar Gala
2009-03-18 18:04   ` Richard Retanubun
2009-03-18 19:01     ` Kumar Gala
2009-03-19  7:47 ` Heiko Schocher
2009-03-25  2:20   ` TC Liew
2009-03-25 12:50     ` Richard Retanubun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49CA2891.3060604@RuggedCom.com \
    --to=richardretanubun@ruggedcom.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox