From mboxrd@z Thu Jan  1 00:00:00 1970
From: Remco Poelstra <remco.poelstra@duran-audio.com>
Date: Thu, 26 Mar 2009 10:10:20 +0100
Subject: [U-Boot] [PATCH 1/2] LPC2468 support
In-Reply-To: <20090325214344.GC18991@game.jcrosoft.org>
References: <49C0F362.50803@duran-audio.com>
	<20090318135854.0ED0A832E8B7@gemini.denx.de>
	<49C10B37.1070506@duran-audio.com>
	<20090318164606.7B26D832E8B7@gemini.denx.de>
	<49C25F75.3080906@duran-audio.com>
	<20090319212230.1AB01832E8B7@gemini.denx.de>
	<49C8BE7A.10504@duran-audio.com>
	<20090324223337.18E5B832E406@gemini.denx.de>
	<49C9EB4D.5050503@duran-audio.com>
	<20090325214344.GC18991@game.jcrosoft.org>
Message-ID: <49CB467C.3050303@duran-audio.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Jean-Christophe PLAGNIOL-VILLARD schreef:
>> No, thumb code is less efficient in terms of performance, but this 
>> single file needs thumb code. See LPC2292.
> what is the Difference?
> 
> until a real big gap please do not use thumb

IAP entries need thumb code. This is not a problem, they are only used 
for programming the internal flash of the processor, so there is no 
performance penalty for normal operation.


>> Yes I do. They are straight from the LPC2292 code, so once they were 
>> considered OK. I checked out the the write{s,l,b} functions in asm/io.h, 
>> but although they look similar, for some reason they simply don't work. 
>> Given the similarities between the write{s,l,b} and the PUT* functions, 
>> what is the problem with those? Furthermore, the ARM architecture 
>> doesn't use any kind of special instructions for accessing registers, 
>> everything is memory mapped.
> please use readx/writex

Thanks for the pointer, I'll look into those.

>> I do understand that you want the best code for U-boot, but I do not 
>> entirely agree on all points. Certainly when I look at the code already 
>> in place in U-boot.
> I'm preparing a patch series to clean the arm720t to seprate it as arch
> and avoid this borring #ifdef

Can you explain what you mean here?

Kind regards,

Remco Poelstra