From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 13/13] ompa3: remove duplicate interrupts code
Date: Sat, 28 Mar 2009 07:24:57 +0100 [thread overview]
Message-ID: <49CDC2B9.3040101@googlemail.com> (raw)
In-Reply-To: <1238191161-7626-13-git-send-email-plagnioj@jcrosoft.com>
Dear Jean-Christophe,
Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
As this patch has no patch description in body (except subject) it
seems that you think that the code you like to remove here is already
available somewhere else. Where?
Please correct typo in subject ('ompa').
Dirk
> ---
> cpu/arm_cortexa8/omap3/interrupts.c | 128 -----------------------------------
> 1 files changed, 0 insertions(+), 128 deletions(-)
>
> diff --git a/cpu/arm_cortexa8/omap3/interrupts.c b/cpu/arm_cortexa8/omap3/interrupts.c
> index 9e9817d..384ffdc 100644
> --- a/cpu/arm_cortexa8/omap3/interrupts.c
> +++ b/cpu/arm_cortexa8/omap3/interrupts.c
> @@ -34,137 +34,9 @@
>
> #include <common.h>
> #include <asm/io.h>
> -#include <asm/proc-armv/ptrace.h>
>
> #define TIMER_LOAD_VAL 0
>
> -#ifdef CONFIG_USE_IRQ
> -/* enable IRQ interrupts */
> -void enable_interrupts(void)
> -{
> - unsigned long temp;
> - __asm__ __volatile__("mrs %0, cpsr\n"
> - "bic %0, %0, #0x80\n" "msr cpsr_c, %0":"=r"(temp)
> - ::"memory");
> -}
> -
> -/*
> - * disable IRQ/FIQ interrupts
> - * returns true if interrupts had been enabled before we disabled them
> - */
> -int disable_interrupts(void)
> -{
> - unsigned long old, temp;
> - __asm__ __volatile__("mrs %0, cpsr\n"
> - "orr %1, %0, #0xc0\n"
> - "msr cpsr_c, %1":"=r"(old), "=r"(temp)
> - ::"memory");
> - return (old & 0x80) == 0;
> -}
> -#else
> -void enable_interrupts(void)
> -{
> - return;
> -}
> -int disable_interrupts(void)
> -{
> - return 0;
> -}
> -#endif
> -
> -void bad_mode(void)
> -{
> - panic("Resetting CPU ...\n");
> - reset_cpu(0);
> -}
> -
> -void show_regs(struct pt_regs *regs)
> -{
> - unsigned long flags;
> - const char *processor_modes[] = {
> - "USER_26", "FIQ_26", "IRQ_26", "SVC_26",
> - "UK4_26", "UK5_26", "UK6_26", "UK7_26",
> - "UK8_26", "UK9_26", "UK10_26", "UK11_26",
> - "UK12_26", "UK13_26", "UK14_26", "UK15_26",
> - "USER_32", "FIQ_32", "IRQ_32", "SVC_32",
> - "UK4_32", "UK5_32", "UK6_32", "ABT_32",
> - "UK8_32", "UK9_32", "UK10_32", "UND_32",
> - "UK12_32", "UK13_32", "UK14_32", "SYS_32",
> - };
> -
> - flags = condition_codes(regs);
> -
> - printf("pc : [<%08lx>] lr : [<%08lx>]\n"
> - "sp : %08lx ip : %08lx fp : %08lx\n",
> - instruction_pointer(regs),
> - regs->ARM_lr, regs->ARM_sp, regs->ARM_ip, regs->ARM_fp);
> - printf("r10: %08lx r9 : %08lx r8 : %08lx\n",
> - regs->ARM_r10, regs->ARM_r9, regs->ARM_r8);
> - printf("r7 : %08lx r6 : %08lx r5 : %08lx r4 : %08lx\n",
> - regs->ARM_r7, regs->ARM_r6, regs->ARM_r5, regs->ARM_r4);
> - printf("r3 : %08lx r2 : %08lx r1 : %08lx r0 : %08lx\n",
> - regs->ARM_r3, regs->ARM_r2, regs->ARM_r1, regs->ARM_r0);
> - printf("Flags: %c%c%c%c",
> - flags & CC_N_BIT ? 'N' : 'n',
> - flags & CC_Z_BIT ? 'Z' : 'z',
> - flags & CC_C_BIT ? 'C' : 'c', flags & CC_V_BIT ? 'V' : 'v');
> - printf(" IRQs %s FIQs %s Mode %s%s\n",
> - interrupts_enabled(regs) ? "on" : "off",
> - fast_interrupts_enabled(regs) ? "on" : "off",
> - processor_modes[processor_mode(regs)],
> - thumb_mode(regs) ? " (T)" : "");
> -}
> -
> -void do_undefined_instruction(struct pt_regs *pt_regs)
> -{
> - printf("undefined instruction\n");
> - show_regs(pt_regs);
> - bad_mode();
> -}
> -
> -void do_software_interrupt(struct pt_regs *pt_regs)
> -{
> - printf("software interrupt\n");
> - show_regs(pt_regs);
> - bad_mode();
> -}
> -
> -void do_prefetch_abort(struct pt_regs *pt_regs)
> -{
> - printf("prefetch abort\n");
> - show_regs(pt_regs);
> - bad_mode();
> -}
> -
> -void do_data_abort(struct pt_regs *pt_regs)
> -{
> - printf("data abort\n");
> - show_regs(pt_regs);
> - bad_mode();
> -}
> -
> -void do_not_used(struct pt_regs *pt_regs)
> -{
> - printf("not used\n");
> - show_regs(pt_regs);
> - bad_mode();
> -}
> -
> -void do_fiq(struct pt_regs *pt_regs)
> -{
> - printf("fast interrupt request\n");
> - show_regs(pt_regs);
> - bad_mode();
> -}
> -
> -void do_irq(struct pt_regs *pt_regs)
> -{
> - printf("interrupt request\n");
> - show_regs(pt_regs);
> - bad_mode();
> -}
> -
> -
> static ulong timestamp;
> static ulong lastinc;
> static gptimer_t *timer_base = (gptimer_t *)CONFIG_SYS_TIMERBASE;
next prev parent reply other threads:[~2009-03-28 6:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 21:59 [U-Boot] [PATCH 01/13] s3c4510b: move specific code to soc directory Jean-Christophe PLAGNIOL-VILLARD
2009-03-27 21:59 ` [U-Boot] [PATCH 02/13] s3c44b0: move i2c driver to drivers/i2c Jean-Christophe PLAGNIOL-VILLARD
2009-03-27 21:59 ` [U-Boot] [PATCH 03/13] s3c44b0: move rtc driver to drivers/rtc Jean-Christophe PLAGNIOL-VILLARD
2009-03-27 21:59 ` [U-Boot] [PATCH 04/13] s3c44b0: move serial driver to drivers/serial Jean-Christophe PLAGNIOL-VILLARD
2009-03-27 21:59 ` [U-Boot] [PATCH 05/13] s3c44b0: extract cache from cpu.c Jean-Christophe PLAGNIOL-VILLARD
2009-03-27 21:59 ` [U-Boot] [PATCH 06/13] sa1100: move serial driver to drivers/serial Jean-Christophe PLAGNIOL-VILLARD
2009-03-27 21:59 ` [U-Boot] [PATCH 07/13] netarm: " Jean-Christophe PLAGNIOL-VILLARD
2009-03-27 21:59 ` [U-Boot] [PATCH 08/13] imx31: " Jean-Christophe PLAGNIOL-VILLARD
2009-03-27 21:59 ` [U-Boot] [PATCH 09/13] s3c64xx: move usb driver to drivers/usb Jean-Christophe PLAGNIOL-VILLARD
2009-03-27 21:59 ` [U-Boot] [PATCH 10/13] ks8695: move serial driver to drivers/serial Jean-Christophe PLAGNIOL-VILLARD
2009-03-27 21:59 ` [U-Boot] [PATCH 11/13] lpc2292: " Jean-Christophe PLAGNIOL-VILLARD
2009-03-27 21:59 ` [U-Boot] [PATCH 12/13] arm720t/clps7111: " Jean-Christophe PLAGNIOL-VILLARD
2009-03-27 21:59 ` [U-Boot] [PATCH 13/13] ompa3: remove duplicate interrupts code Jean-Christophe PLAGNIOL-VILLARD
2009-03-28 6:24 ` Dirk Behme [this message]
2009-03-28 7:59 ` Jean-Christophe PLAGNIOL-VILLARD
2009-03-28 8:42 ` Dirk Behme
2009-03-31 18:26 ` [U-Boot] [PATCH 09/13] s3c64xx: move usb driver to drivers/usb Remy Bohmer
2009-03-31 19:24 ` Jean-Christophe PLAGNIOL-VILLARD
2009-03-31 21:06 ` Wolfgang Denk
2009-03-30 5:31 ` [U-Boot] [PATCH 02/13] s3c44b0: move i2c driver to drivers/i2c Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49CDC2B9.3040101@googlemail.com \
--to=dirk.behme@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox