From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Patch] soft_i2c.c compiler/linker error
Date: Mon, 30 Mar 2009 07:22:44 +0200 [thread overview]
Message-ID: <49D05724.7050503@denx.de> (raw)
In-Reply-To: <20090327104606.GB7185@game.jcrosoft.org>
Hello Jean-Christophe
Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 11:31 Fri 27 Mar , Jens Scharsig wrote:
>
>> This patch fix the compiler/linker errors
>>
>> common/cmd_i2c.c:1252: undefined reference to `i2c_get_bus_speed'
>> common/cmd_i2c.c:1256: undefined reference to `i2c_set_bus_speed'
>>
>> if board use CONFIG_I2C_CMD_TREE and CONFIG_I2C_MULTI_BUS is not uesd/undef
>>
>> Signed-off-by: Jens Scharsig <esw@bus-elektronik.de>
>>
> NACK
>
> you must implement it
>
It is implemented in the driver, but not activated, because
wrong define order ... I think this patch is OK.
bye
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2009-03-30 5:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 10:31 [U-Boot] [Patch] soft_i2c.c compiler/linker error Jens Scharsig
2009-03-27 10:46 ` Jean-Christophe PLAGNIOL-VILLARD
2009-03-27 11:30 ` Jens Scharsig
2009-03-30 5:22 ` Heiko Schocher [this message]
2009-03-30 8:00 ` Jens Scharsig
2009-03-30 5:21 ` Heiko Schocher
2009-03-30 7:51 ` [U-Boot] [Patch V2] " Jens Scharsig
2009-03-31 6:32 ` Heiko Schocher
2009-03-31 6:18 ` [U-Boot] [Patch V2.1] " Jens Scharsig
2009-03-31 7:08 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D05724.7050503@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox