[U-Boot] [RFC PATCH V2] drivers/usb: regorganisation

Wolfgang Denk
2009-04-02T18:07:07Z

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <1238691332-27548-1-git-send-email-plagnioj@jcrosoft.com> you wrote:
> move to linux usb driver organisation
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> Cc: Remy Bohmer <linux@bohmer.net>
> ---
> Remy is this one ok for you?

Looks OK to me, but..

> diff --git a/drivers/serial/usbtty.c b/drivers/serial/usbtty.c
> index d8b1387..71f0e5b 100644
> --- a/drivers/serial/usbtty.c
> +++ b/drivers/serial/usbtty.c
> @@ -94,7 +94,7 @@ static char serial_number[16];
> * Descriptors, Strings, Local variables.
> */
>
> -/* defined and used by usbdcore_ep0.c */
> +/* defined and used by ep0.c */
> extern struct usb_string_descriptor **usb_strings;

This is now too short. Where might ep0.c be? Please use "gadget/ep0.c"
here.

> rename to drivers/usb/gadget/mpc8xx_udc.c
> index 0e311ad..8d7bd65 100644
> --- a/drivers/usb/usbdcore_mpc8xx.c
> +++ b/drivers/usb/gadget/mpc8xx_udc.c
> @@ -3,7 +3,7 @@
> * bodonoghue at CodeHermit.ie
> *
> * References
> - * DasUBoot/drivers/usb/usbdcore_omap1510.c, for design and implementation
> + * DasUBoot/drivers/usb/omap1510_udc.c, for design and implementation

Please change into "drivers/usb/omap1510_udc.c"

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When a woman marries again it is because she detested her first hus-
band. When a man marries again, it is because he adored his first
wife. -- Oscar Wilde