From: Michael Trimarchi <trimarchi@gandalf.sssup.it>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 10/13] at91: move usb driver to drivers/usb
Date: Wed, 01 Apr 2009 10:59:08 +0200 [thread overview]
Message-ID: <49D32CDC.4010203@gandalf.sssup.it> (raw)
In-Reply-To: <20090401081350.GC23893@game.jcrosoft.org>
Hi,
Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 09:57 Wed 01 Apr , Remy Bohmer wrote:
>
>> Hello Jean-Christophe,
>>
>>
>>>> And that is exactly the issue here. The discussion is about moving
>>>> 'platform USB init code' to generic driver code.
>>>> I would have no problems with moving real USB drivers to the generic
>>>> driver section, if they are cleaned from board specific code, of
>>>> course.
>>>>
>>> in our case it's not a cpu specify init but an IP init which is share to
>>> multiple soc for multiple arch
>>>
>> IMHO, that still does not justify it to make it part of the generic drivers.
>> And I already mentioned yesterday, that I agree that it does not
>> really belong in the cpu section as well.
>> We should not pollute one area by cleaning another area.
>>
>> So, we seem to be lacking a SoC/board specific section, like the linux
>> kernel handles it.
>>
> btw in linux the similar usb code is here
> drivers/usb/host/ohci-at91.c
>
> Best Regards,
> J.
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
>
It is just a glue code in linux. Maybe it will be simple if you create a
core direcory
and a host directory under the usb. An move the specific part in the host.
Michael
next prev parent reply other threads:[~2009-04-01 8:59 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 22:30 [U-Boot] [PATCH 01/13 V2] at91sam9/at91cap: spi init add hardware chip select support Jean-Christophe PLAGNIOL-VILLARD
2009-03-27 22:30 ` [U-Boot] [PATCH 02/13 V2] at91sam9: add watchdog support Jean-Christophe PLAGNIOL-VILLARD
2009-03-27 22:30 ` [U-Boot] [PATCH 03/13] at91: rename DATAFLASH_MMC_SELECT to CONFIG_DATAFLASH_MMC_SELECT Jean-Christophe PLAGNIOL-VILLARD
2009-03-27 22:30 ` [U-Boot] [PATCH 04/13] at91rm9200dk: Move conditional compilation to Makefile Jean-Christophe PLAGNIOL-VILLARD
2009-03-27 22:30 ` [U-Boot] [PATCH 05/13] add dataflash mmc mux missing support Jean-Christophe PLAGNIOL-VILLARD
2009-03-27 22:30 ` [U-Boot] [PATCH 06/13] Add support for the AT91RM9200EK Board Jean-Christophe PLAGNIOL-VILLARD
2009-03-27 22:30 ` [U-Boot] [PATCH 07/13] at91rm9200: move serial driver to drivers/serial Jean-Christophe PLAGNIOL-VILLARD
2009-03-27 22:30 ` [U-Boot] [PATCH 08/13] at91rm9200: move serial shutdown code to serial drivers Jean-Christophe PLAGNIOL-VILLARD
2009-03-27 22:30 ` [U-Boot] [PATCH 09/13] at91rm9200: Reset update Jean-Christophe PLAGNIOL-VILLARD
2009-03-27 22:30 ` [U-Boot] [PATCH 10/13] at91: move usb driver to drivers/usb Jean-Christophe PLAGNIOL-VILLARD
2009-03-27 22:30 ` [U-Boot] [PATCH 11/13] at91: move dataflash spi driver to drivers/spi Jean-Christophe PLAGNIOL-VILLARD
2009-03-27 22:30 ` [U-Boot] [PATCH 12/13] at91: add hardware i2c drivers Jean-Christophe PLAGNIOL-VILLARD
2009-03-27 22:30 ` [U-Boot] [PATCH 13/13] at91sam9263ek: active hush and auto compelete support Jean-Christophe PLAGNIOL-VILLARD
2009-03-31 20:35 ` Wolfgang Denk
2009-03-31 22:42 ` Stelian Pop
2009-03-30 5:53 ` [U-Boot] [PATCH 12/13] at91: add hardware i2c drivers Heiko Schocher
2009-03-30 7:24 ` Jean-Christophe PLAGNIOL-VILLARD
2009-03-30 8:26 ` Heiko Schocher
2009-03-30 8:50 ` Jean-Christophe PLAGNIOL-VILLARD
2009-03-30 10:43 ` Wolfgang Denk
2009-03-30 11:55 ` Jean-Christophe PLAGNIOL-VILLARD
2009-03-31 20:40 ` Wolfgang Denk
2009-05-14 6:06 ` Daniel Gorsulowski
2009-03-31 18:28 ` [U-Boot] [PATCH 10/13] at91: move usb driver to drivers/usb Remy Bohmer
2009-03-31 19:21 ` Jean-Christophe PLAGNIOL-VILLARD
2009-03-31 20:38 ` Wolfgang Denk
2009-03-31 21:55 ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-01 6:55 ` Stefan Roese
2009-04-01 7:25 ` Remy Bohmer
2009-04-01 7:22 ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-01 7:57 ` Remy Bohmer
2009-04-01 8:01 ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-01 9:07 ` Wolfgang Denk
2009-04-01 8:13 ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-01 8:59 ` Michael Trimarchi [this message]
2009-04-01 9:27 ` Stefan Roese
2009-04-01 9:44 ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-01 12:19 ` Stefan Roese
2009-04-01 17:21 ` [U-Boot] [RFC PATCH] drivers/usb: regorganisation Jean-Christophe PLAGNIOL-VILLARD
2009-04-01 22:12 ` Wolfgang Denk
2009-04-02 5:22 ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-02 15:26 ` Remy Bohmer
2009-04-02 16:55 ` [U-Boot] [RFC PATCH V2] " Jean-Christophe PLAGNIOL-VILLARD
2009-04-02 18:07 ` Wolfgang Denk
2009-04-02 19:27 ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-02 23:06 ` Wolfgang Denk
2009-04-03 5:10 ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-03 10:46 ` [U-Boot] [PATCH] " Jean-Christophe PLAGNIOL-VILLARD
2009-04-03 11:19 ` Remy Bohmer
2009-04-02 11:11 ` [U-Boot] [RFC PATCH] " Mike Frysinger
2009-04-01 15:56 ` [U-Boot] [PATCH 10/13] at91: move usb driver to drivers/usb ksi at koi8.net
2009-04-01 15:53 ` ksi at koi8.net
2009-04-01 15:48 ` ksi at koi8.net
2009-04-01 16:03 ` Michael Trimarchi
2009-04-01 16:31 ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-01 16:28 ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-01 19:42 ` Scott Wood
2009-03-31 21:22 ` Remy Bohmer
2009-03-31 20:36 ` Wolfgang Denk
2009-04-01 22:15 ` [U-Boot] [PATCH 08/13] at91rm9200: move serial shutdown code to serial drivers Wolfgang Denk
2009-04-01 22:14 ` [U-Boot] [PATCH 07/13] at91rm9200: move serial driver to drivers/serial Wolfgang Denk
2009-05-26 15:47 ` [U-Boot] [PATCH 06/13] Add support for the AT91RM9200EK Board Haavard Skinnemoen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D32CDC.4010203@gandalf.sssup.it \
--to=trimarchi@gandalf.sssup.it \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox