From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Trimarchi Date: Wed, 01 Apr 2009 10:59:08 +0200 Subject: [U-Boot] [PATCH 10/13] at91: move usb driver to drivers/usb In-Reply-To: <20090401081350.GC23893@game.jcrosoft.org> References: <1238193026-12564-2-git-send-email-plagnioj@jcrosoft.com> <20090331192117.GF24923@game.jcrosoft.org> <20090331203822.60DED83797DC@gemini.denx.de> <200904010855.55698.sr@denx.de> <3efb10970904010025u5ea748c3w8be6990f8527ea66@mail.gmail.com> <20090401072244.GA23893@game.jcrosoft.org> <3efb10970904010057k1e7b3759k2b24ad483af96ae5@mail.gmail.com> <20090401081350.GC23893@game.jcrosoft.org> Message-ID: <49D32CDC.4010203@gandalf.sssup.it> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 09:57 Wed 01 Apr , Remy Bohmer wrote: > >> Hello Jean-Christophe, >> >> >>>> And that is exactly the issue here. The discussion is about moving >>>> 'platform USB init code' to generic driver code. >>>> I would have no problems with moving real USB drivers to the generic >>>> driver section, if they are cleaned from board specific code, of >>>> course. >>>> >>> in our case it's not a cpu specify init but an IP init which is share to >>> multiple soc for multiple arch >>> >> IMHO, that still does not justify it to make it part of the generic drivers. >> And I already mentioned yesterday, that I agree that it does not >> really belong in the cpu section as well. >> We should not pollute one area by cleaning another area. >> >> So, we seem to be lacking a SoC/board specific section, like the linux >> kernel handles it. >> > btw in linux the similar usb code is here > drivers/usb/host/ohci-at91.c > > Best Regards, > J. > _______________________________________________ > U-Boot mailing list > U-Boot at lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot > > It is just a glue code in linux. Maybe it will be simple if you create a core direcory and a host directory under the usb. An move the specific part in the host. Michael