[U-Boot] [PATCH] ZOOM2 Add initial support for Zoom2

Tom
2009-04-01T20:46:48Z

Scott Wood wrote:
> On Wed, Apr 01, 2009 at 11:11:09AM -0500, Tom Rix wrote:
>
>> +#define WRITE_NAND_COMMAND(d, adr)\
>> + writel(d, &nand_cs_base->nand_cmd)
>> +#define WRITE_NAND_ADDRESS(d, adr)\
>> + writel(d, &nand_cs_base->nand_adr)
>> +#define WRITE_NAND(d, adr) writew(d, &nand_cs_base->nand_dat)
>> +#define READ_NAND(adr) readl(&nand_cs_base->nand_dat)
>> +
>> +/* Other NAND Access APIs */
>> +#define NAND_WP_OFF() do {readl(&gpmc_cfg_base->config) |= GPMC_CONFIG_WP; } \
>> + while (0)
>> +#define NAND_WP_ON() do {readl(&gpmc_cfg_base->config) &= ~GPMC_CONFIG_WP; } \
>> + while (0)
>> +#define NAND_DISABLE_CE(nand)
>> +#define NAND_ENABLE_CE(nand)
>> +#define NAND_WAIT_READY(nand) udelay(10)
>>
>
> This is the legacy NAND interface which is deprecated and will be removed
> very soon. You don't seem to be selecting legacy NAND support, so these
> defines (and some others earlier in the file) are just dead code. Please
> remove them.
>
>
OK
Since this was a copy from Zoom1, I will also change Zoom1.

> -Scott
>