From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tom <Tom.Rix@windriver.com>
Date: Wed, 01 Apr 2009 15:46:48 -0500
Subject: [U-Boot] [PATCH] ZOOM2 Add initial support for Zoom2
In-Reply-To: <20090401195126.GB28740@ld0162-tx32.am.freescale.net>
References: <1238602273-27252-1-git-send-email-Tom.Rix@windriver.com>
	<20090401195126.GB28740@ld0162-tx32.am.freescale.net>
Message-ID: <49D3D2B8.4050104@windriver.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Scott Wood wrote:
> On Wed, Apr 01, 2009 at 11:11:09AM -0500, Tom Rix wrote:
>   
>> +#define WRITE_NAND_COMMAND(d, adr)\
>> +			writel(d, &nand_cs_base->nand_cmd)
>> +#define WRITE_NAND_ADDRESS(d, adr)\
>> +			writel(d, &nand_cs_base->nand_adr)
>> +#define WRITE_NAND(d, adr) writew(d, &nand_cs_base->nand_dat)
>> +#define READ_NAND(adr) readl(&nand_cs_base->nand_dat)
>> +
>> +/* Other NAND Access APIs */
>> +#define NAND_WP_OFF() do {readl(&gpmc_cfg_base->config) |= GPMC_CONFIG_WP; } \
>> +			while (0)
>> +#define NAND_WP_ON() do {readl(&gpmc_cfg_base->config) &= ~GPMC_CONFIG_WP; } \
>> +			while (0)
>> +#define NAND_DISABLE_CE(nand)
>> +#define NAND_ENABLE_CE(nand)
>> +#define NAND_WAIT_READY(nand)	udelay(10)
>>     
>
> This is the legacy NAND interface which is deprecated and will be removed
> very soon.  You don't seem to be selecting legacy NAND support, so these
> defines (and some others earlier in the file) are just dead code.  Please
> remove them.
>
>   
OK
Since this was a copy from Zoom1, I will also change Zoom1.

> -Scott
>