From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Wed, 01 Apr 2009 16:32:49 -0500 Subject: [U-Boot] [PATCH] Noisily disable the legacy NAND subsystem. In-Reply-To: <78B9486C-B641-49A6-A1D9-9BBB3B7D04AE@kernel.crashing.org> References: <20090401211543.GA10944@ld0162-tx32.am.freescale.net> <78B9486C-B641-49A6-A1D9-9BBB3B7D04AE@kernel.crashing.org> Message-ID: <49D3DD81.4050508@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Becky Bruce wrote: > > On Apr 1, 2009, at 4:15 PM, Scott Wood wrote: > >> Legacy NAND is marked for feature removal after April 2009 (i.e. this >> upcoming release). There are still several boards that reference it >> (though many do so only for disk-on-chip support which has been silently >> disabled for a while now). These boards will now fail to build with > > Drum roll....? You're missing the rest of your sentence, or you have > too much sentence, or something. D'oh. The next line started with "#error", so git treated it as a comment. Commit amended to say "These boards will now fail to build with #error, though the code is still there if the user removes #error." >> +#error This code is broken and will be removed outright in the next >> release. >> +#error If you need diskonchip support, please update >> +#error drivers/mtd/nand/diskonchip.c to work with u-boot. > > "to work with u-boot"? As opposed to what, exactly? Linux, where the code was taken from as part of the NAND subsystem importation. > How about "please update blah to be functional" "be functional" == "work". I was just clarifying the nature of the fixing that needed to be done. -Scott