From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ZOOM2 Add initial support for Zoom2
Date: Wed, 01 Apr 2009 19:53:42 -0500 [thread overview]
Message-ID: <49D40C96.3090508@windriver.com> (raw)
In-Reply-To: <20090401201927.B467D83797DC@gemini.denx.de>
Wolfgang Denk wrote:
> Dear Tom Rix,
>
> In message <1238602273-27252-1-git-send-email-Tom.Rix@windriver.com> you wrote:
>
>> Zoom2 is a new board from Texas Instruments and LogicPD
>> This is the product description
>> http://www.logicpd.com/products/development-kits/texas-instruments-zoom%E2%84%A2-omap34x-ii-mdp
>>
>> This patch provides a zoom2 base target by copying zoom1 and by making some
>> obvious changes. This target compiles but does not yet run.
>>
>> To configure, run
>> make omap3_zoom2_config
>>
> ...
>
>> diff --git a/board/omap3/zoom2/zoom2.c b/board/omap3/zoom2/zoom2.c
>> new file mode 100644
>> index 0000000..f861691
>> --- /dev/null
>> +++ b/board/omap3/zoom2/zoom2.c
>>
> ...
>
>> +/******************************************************************************
>> + * Routine: board_init
>> + * Description: Early hardware init.
>> + *****************************************************************************/
>>
>
> Here and everywhere else: incorrect multiline comment style. Please
> fix everywhere.
>
>
>
This is common in all the omap3 board files.
I will fix these as well.
>> diff --git a/include/configs/omap3_zoom2.h b/include/configs/omap3_zoom2.h
>> new file mode 100644
>> index 0000000..9ea8ea0
>>
> ...
>
>> +/* Clock Defines */
>> +#define V_OSCK 26000000 /* Clock output from T2 */
>>
>
> Here and in some other places: line too long. Please fix everywhere.
>
>
>
>
OK
> Best regards,
>
> Wolfgang Denk
>
>
next prev parent reply other threads:[~2009-04-02 0:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-01 16:11 [U-Boot] [PATCH] ZOOM2 Add initial support for Zoom2 Tom Rix
2009-04-01 16:11 ` [U-Boot] [PATCH] ZOOM2 Mux changes to support zoom2 configuration Tom Rix
2009-04-01 16:11 ` [U-Boot] [PATCH] ZOOM2 Add support for debug board detection Tom Rix
2009-04-01 16:11 ` [U-Boot] [PATCH] ZOOM2 Add serial support Tom Rix
2009-04-01 16:11 ` [U-Boot] [PATCH] ZOOM2 Add led support Tom Rix
2009-04-01 20:25 ` [U-Boot] [PATCH] ZOOM2 Add serial support Wolfgang Denk
2009-04-01 20:45 ` Tom
2009-04-01 21:36 ` Wolfgang Denk
2009-04-01 20:21 ` [U-Boot] [PATCH] ZOOM2 Add support for debug board detection Wolfgang Denk
2009-04-01 19:51 ` [U-Boot] [PATCH] ZOOM2 Add initial support for Zoom2 Scott Wood
2009-04-01 20:46 ` Tom
2009-04-01 20:19 ` Wolfgang Denk
2009-04-02 0:53 ` Tom [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-04-01 19:07 Tom Rix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D40C96.3090508@windriver.com \
--to=tom.rix@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox