public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] s3c64xx: support the soft reset at s3c6410
@ 2009-04-02 10:36 Minkyu Kang
  2009-04-02 10:42 ` Jean-Christophe PLAGNIOL-VILLARD
  0 siblings, 1 reply; 3+ messages in thread
From: Minkyu Kang @ 2009-04-02 10:36 UTC (permalink / raw)
  To: u-boot

This patch support the soft reset at s3c6410

Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
---
 cpu/arm1176/cpu.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/cpu/arm1176/cpu.c b/cpu/arm1176/cpu.c
index 1e94f7d..cb13d9c 100644
--- a/cpu/arm1176/cpu.c
+++ b/cpu/arm1176/cpu.c
@@ -112,7 +112,11 @@ int cleanup_before_linux (void)
 void reset_cpu (ulong ignored)
 {
 	printf("reset... \n\n\n");
+#if defined(CONFIG_S3C6410)
+	SW_RST_REG = 0x6410;
+#else
 	SW_RST_REG = 0x6400;
+#endif
 	/* loop forever and wait for reset to happen */
 	while (1) {
 		if (serial_tstc()) {

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] s3c64xx: support the soft reset at s3c6410
  2009-04-02 10:36 [U-Boot] [PATCH] s3c64xx: support the soft reset at s3c6410 Minkyu Kang
@ 2009-04-02 10:42 ` Jean-Christophe PLAGNIOL-VILLARD
  2009-06-09 19:41   ` Jean-Christophe PLAGNIOL-VILLARD
  0 siblings, 1 reply; 3+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2009-04-02 10:42 UTC (permalink / raw)
  To: u-boot

On 19:36 Thu 02 Apr     , Minkyu Kang wrote:
> This patch support the soft reset at s3c6410
> 
> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
> ---
>  cpu/arm1176/cpu.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/cpu/arm1176/cpu.c b/cpu/arm1176/cpu.c
> index 1e94f7d..cb13d9c 100644
> --- a/cpu/arm1176/cpu.c
> +++ b/cpu/arm1176/cpu.c
> @@ -112,7 +112,11 @@ int cleanup_before_linux (void)
>  void reset_cpu (ulong ignored)
>  {
>  	printf("reset... \n\n\n");
> +#if defined(CONFIG_S3C6410)
> +	SW_RST_REG = 0x6410;
> +#else
>  	SW_RST_REG = 0x6400;
> +#endif
this is soc specific please move to the soc
and please use proper accessor

Best Regards,
J.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] s3c64xx: support the soft reset at s3c6410
  2009-04-02 10:42 ` Jean-Christophe PLAGNIOL-VILLARD
@ 2009-06-09 19:41   ` Jean-Christophe PLAGNIOL-VILLARD
  0 siblings, 0 replies; 3+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2009-06-09 19:41 UTC (permalink / raw)
  To: u-boot

On 12:42 Thu 02 Apr     , Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 19:36 Thu 02 Apr     , Minkyu Kang wrote:
> > This patch support the soft reset at s3c6410
> > 
> > Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
> > ---
> >  cpu/arm1176/cpu.c |    4 ++++
> >  1 files changed, 4 insertions(+), 0 deletions(-)
> > 
> > diff --git a/cpu/arm1176/cpu.c b/cpu/arm1176/cpu.c
> > index 1e94f7d..cb13d9c 100644
> > --- a/cpu/arm1176/cpu.c
> > +++ b/cpu/arm1176/cpu.c
> > @@ -112,7 +112,11 @@ int cleanup_before_linux (void)
> >  void reset_cpu (ulong ignored)
> >  {
> >  	printf("reset... \n\n\n");
> > +#if defined(CONFIG_S3C6410)
> > +	SW_RST_REG = 0x6410;
> > +#else
> >  	SW_RST_REG = 0x6400;
> > +#endif
> this is soc specific please move to the soc
> and please use proper accessor
ping

will you send a new version soon

Best Regards,
J.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-06-09 19:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-02 10:36 [U-Boot] [PATCH] s3c64xx: support the soft reset at s3c6410 Minkyu Kang
2009-04-02 10:42 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-09 19:41   ` Jean-Christophe PLAGNIOL-VILLARD

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox