From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Warren <biggerbadderben@gmail.com>
Date: Thu, 02 Apr 2009 15:02:31 -0700
Subject: [U-Boot] [PATCH] Network AT91 AVR32: generic way of addressing
 USRIO register layout
In-Reply-To: <20090402202856.GH15621@game.jcrosoft.org>
References: <49C74F51.1040401@atmel.com>
	<20090323092245.GA17258@game.jcrosoft.org>
	<20090323104156.0e741f8e@hskinnemoen-d830>
	<20090402202856.GH15621@game.jcrosoft.org>
Message-ID: <49D535F7.6040300@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 10:41 Mon 23 Mar     , Haavard Skinnemoen wrote:
>   
>> Jean-Christophe PLAGNIOL-VILLARD wrote:
>>     
>>> On 09:58 Mon 23 Mar     , Nicolas Ferre wrote:
>>>       
>>>> The MACB IP used by AVR32 & AT91 have two different layout for USRIO
>>>> register. We have to differentiate this in the driver code.
>>>> No more cpu specific #ifdefs in driver: we manage a
>>>> configuration variable.
>>>>
>>>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>  
>>>>         
>>> Ack-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
>>>
>>> Haavard is ok for you too?
>>>       
>> Sure.
>>
>> Acked-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
>>     
> Ben is ok for you?
>   
It's definitely an improvement, although I'm not fond of placing the 
conditional macro in the header file.  Overall OK, though.  I'll pick it up.

regards,
Ben