public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/8] ZOOM2 Add support for debug board detection.
Date: Sat, 04 Apr 2009 10:28:13 +0200	[thread overview]
Message-ID: <49D71A1D.6090909@googlemail.com> (raw)
In-Reply-To: <1238641341-26714-3-git-send-email-Tom.Rix@windriver.com>

Hi Tom,

Tom Rix wrote:
> https://omapzoom.org/gf/project/omapzoom/wiki/?pagename=GettingStartedWithZoomII_AKA_OMAP34XII_MDP
> 
> The zoom2 has an auxillary board that contains the serial, net, jtag and
> battery simulator.  This change supports a runtime check if the debug board is
> connected.
> 
> Signed-off-by: Tom Rix <Tom.Rix@windriver.com>
> ---
>  board/omap3/zoom2/Makefile      |    3 +-
>  board/omap3/zoom2/debug_board.c |   57 +++++++++++++++++++++++++++++++++++++++
>  2 files changed, 59 insertions(+), 1 deletions(-)
>  create mode 100644 board/omap3/zoom2/debug_board.c
> 
> diff --git a/board/omap3/zoom2/Makefile b/board/omap3/zoom2/Makefile
> index 088b8cb..b8fa5a7 100644
> --- a/board/omap3/zoom2/Makefile
> +++ b/board/omap3/zoom2/Makefile
> @@ -25,7 +25,8 @@ include $(TOPDIR)/config.mk
...
> --- /dev/null
> +++ b/board/omap3/zoom2/debug_board.c
...
> +static void zoom2_debug_board_detect (void)
> +{
> +	unsigned int val;
> +	/*
> +	 * GPIO to query for debug board
> +	 * 158 db board query, bank 5, index 30
> +	 */
> +	gpio_t *gpio5_base = (gpio_t *) OMAP34XX_GPIO5_BASE;
> +
> +	val = __raw_readl (&gpio5_base->datain);

Is there any special reason why you use __raw_readl() instead of just 
readl() here? Looking at ARM's io.h, they seem to map to the same macro?

Best regards

Dirk

  parent reply	other threads:[~2009-04-04  8:28 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-02  3:02 [U-Boot] [PATCH 1/8] ZOOM2 Add initial support for Zoom2 Tom Rix
2009-04-02  3:02 ` [U-Boot] [PATCH 2/8] ZOOM2 Mux changes to support zoom2 configuration Tom Rix
2009-04-02  3:02   ` [U-Boot] [PATCH 3/8] ZOOM2 Add support for debug board detection Tom Rix
2009-04-02  3:02     ` [U-Boot] [PATCH 4/8] ZOOM2 Add serial support Tom Rix
2009-04-02  3:02       ` [U-Boot] [PATCH 5/8] ZOOM2 Add led support Tom Rix
2009-04-02  3:02         ` [U-Boot] [PATCH 6/8] ZOOM1 Remove legacy NAND defines Tom Rix
2009-04-02  3:02           ` [U-Boot] [PATCH 7/8] OMAP3 Fix multiline formatting in board init files Tom Rix
2009-04-02  3:02             ` [U-Boot] [PATCH 8/8] ZOOM2: rename timer divisor Tom Rix
2009-04-02  5:35               ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-02  7:00                 ` Wolfgang Denk
2009-04-02  5:33             ` [U-Boot] [PATCH 7/8] OMAP3 Fix multiline formatting in board init files Jean-Christophe PLAGNIOL-VILLARD
2009-04-02  5:34           ` [U-Boot] [PATCH 6/8] ZOOM1 Remove legacy NAND defines Jean-Christophe PLAGNIOL-VILLARD
2009-04-02  5:30         ` [U-Boot] [PATCH 5/8] ZOOM2 Add led support Jean-Christophe PLAGNIOL-VILLARD
2009-04-02 13:38           ` Tom
2009-04-02 13:26             ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-02 20:21       ` [U-Boot] [PATCH 4/8] ZOOM2 Add serial support Jean-Christophe PLAGNIOL-VILLARD
2009-04-02 19:51     ` [U-Boot] [PATCH 3/8] ZOOM2 Add support for debug board detection Jean-Christophe PLAGNIOL-VILLARD
2009-04-03  1:42       ` Tom
2009-04-04  8:28     ` Dirk Behme [this message]
2009-04-04 11:56       ` Tom
2009-04-02  5:34   ` [U-Boot] [PATCH 2/8] ZOOM2 Mux changes to support zoom2 configuration Jean-Christophe PLAGNIOL-VILLARD
2009-04-02 13:40     ` Tom
2009-04-02 16:38 ` [U-Boot] [PATCH 1/8] ZOOM2 Add initial support for Zoom2 Scott Wood
2009-04-02 19:49   ` Tom
2009-04-02 20:02 ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-04  8:27 ` Dirk Behme
2009-04-04 11:54   ` Tom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49D71A1D.6090909@googlemail.com \
    --to=dirk.behme@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox