public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] s3c64xx: remove unnecessary definition
@ 2009-04-06 10:59 Minkyu Kang
  2009-04-17  6:01 ` Jean-Christophe PLAGNIOL-VILLARD
  0 siblings, 1 reply; 3+ messages in thread
From: Minkyu Kang @ 2009-04-06 10:59 UTC (permalink / raw)
  To: u-boot

CONFIG_S3C6400 is must defined at config header file
That definition is unnecessary at this file

Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
---
 include/s3c6400.h |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/include/s3c6400.h b/include/s3c6400.h
index 87f3760..e527c08 100644
--- a/include/s3c6400.h
+++ b/include/s3c6400.h
@@ -31,10 +31,6 @@
 #ifndef __S3C6400_H__
 #define __S3C6400_H__
 
-#ifndef CONFIG_S3C6400
-#define CONFIG_S3C6400		1
-#endif
-
 #define S3C64XX_UART_CHANNELS	3
 #define S3C64XX_SPI_CHANNELS	2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] s3c64xx: remove unnecessary definition
  2009-04-06 10:59 [U-Boot] [PATCH] s3c64xx: remove unnecessary definition Minkyu Kang
@ 2009-04-17  6:01 ` Jean-Christophe PLAGNIOL-VILLARD
  2009-04-27 22:59   ` Wolfgang Denk
  0 siblings, 1 reply; 3+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2009-04-17  6:01 UTC (permalink / raw)
  To: u-boot

On 19:59 Mon 06 Apr     , Minkyu Kang wrote:
> CONFIG_S3C6400 is must defined at config header file
> That definition is unnecessary at this file
> 
> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
> ---
>  include/s3c6400.h |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
applied

Best Regards,
J.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] s3c64xx: remove unnecessary definition
  2009-04-17  6:01 ` Jean-Christophe PLAGNIOL-VILLARD
@ 2009-04-27 22:59   ` Wolfgang Denk
  0 siblings, 0 replies; 3+ messages in thread
From: Wolfgang Denk @ 2009-04-27 22:59 UTC (permalink / raw)
  To: u-boot

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20090417060137.GO31923@game.jcrosoft.org> you wrote:
> On 19:59 Mon 06 Apr     , Minkyu Kang wrote:
> > CONFIG_S3C6400 is must defined at config header file
> > That definition is unnecessary at this file
> > 
> > Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
> > ---
> >  include/s3c6400.h |    4 ----
> >  1 files changed, 0 insertions(+), 4 deletions(-)
> applied

May I see a pull request for this, please?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Do not follow where the path may lead....go instead where there is no
path and leave a trail.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-04-27 22:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-06 10:59 [U-Boot] [PATCH] s3c64xx: remove unnecessary definition Minkyu Kang
2009-04-17  6:01 ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-27 22:59   ` Wolfgang Denk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox