public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Richard Retanubun <RichardRetanubun@RuggedCom.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add I2C speed and divider formula for ColdFire
Date: Wed, 15 Apr 2009 12:20:12 -0400	[thread overview]
Message-ID: <49E6093C.6010404@RuggedCom.com> (raw)
In-Reply-To: <ed82fe3e0904091815t38eda371s7cc6390b632bf879@mail.gmail.com>

Hi TC,

Sorry for the delay, but I was the original complainer about this issue and finally got a chance to try it out.

Timur Tabi wrote:
> On Thu, Apr 9, 2009 at 11:18 AM, Tsi-Chung Liew
> <Tsi-Chung.Liew@freescale.com> wrote:
>> From: TsiChung Liew <Tsi-Chung.Liew@freescale.com>
>>
>> Implement formula to obtain I2C speed and internal bus
>> divider. This will provide accurate divider than fix table
>> divider value.
> 
> Can you prove this statement?

And the code and boot message thinks it is 390 KHz

U-Boot 2009.03dvl-00089-g61e51f7 (Apr 15 2009 - 11:20:06)

CPU:   Freescale ColdFire MCF5270 rev. 1, at 150 MHz
I2C:   390 kHz, ready
[snip]
=> i2c speed
Current bus speed=390625

My probed i2c clock changes from 390KHz (with my patch) to 2MHz with your patch (the ideal being 400KHz)

so NAK from me as well.

- Richard

      reply	other threads:[~2009-04-15 16:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-09 16:18 [U-Boot] [PATCH] Add I2C speed and divider formula for ColdFire Tsi-Chung Liew
2009-04-10  1:15 ` Timur Tabi
2009-04-15 16:20   ` Richard Retanubun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49E6093C.6010404@RuggedCom.com \
    --to=richardretanubun@ruggedcom.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox