From mboxrd@z Thu Jan  1 00:00:00 1970
From: Richard Retanubun <RichardRetanubun@RuggedCom.com>
Date: Wed, 15 Apr 2009 12:20:12 -0400
Subject: [U-Boot] [PATCH] Add I2C speed and divider formula for ColdFire
In-Reply-To: <ed82fe3e0904091815t38eda371s7cc6390b632bf879@mail.gmail.com>
References: <1239293926-17137-1-git-send-email-Tsi-Chung.Liew@freescale.com>
	<ed82fe3e0904091815t38eda371s7cc6390b632bf879@mail.gmail.com>
Message-ID: <49E6093C.6010404@RuggedCom.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi TC,

Sorry for the delay, but I was the original complainer about this issue and finally got a chance to try it out.

Timur Tabi wrote:
> On Thu, Apr 9, 2009 at 11:18 AM, Tsi-Chung Liew
> <Tsi-Chung.Liew@freescale.com> wrote:
>> From: TsiChung Liew <Tsi-Chung.Liew@freescale.com>
>>
>> Implement formula to obtain I2C speed and internal bus
>> divider. This will provide accurate divider than fix table
>> divider value.
> 
> Can you prove this statement?

And the code and boot message thinks it is 390 KHz

U-Boot 2009.03dvl-00089-g61e51f7 (Apr 15 2009 - 11:20:06)

CPU:   Freescale ColdFire MCF5270 rev. 1, at 150 MHz
I2C:   390 kHz, ready
[snip]
=> i2c speed
Current bus speed=390625

My probed i2c clock changes from 390KHz (with my patch) to 2MHz with your patch (the ideal being 400KHz)

so NAK from me as well.

- Richard