public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jerry Van Baren <gerald.vanbaren@ge.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/7] Remove individual I2C commands and cleanup
Date: Fri, 17 Apr 2009 09:32:12 -0400	[thread overview]
Message-ID: <49E884DC.2090204@ge.com> (raw)
In-Reply-To: <49E81FB9.5000902@denx.de>

Heiko Schocher wrote:
> Hello Peter,
> 
> Peter Tyser wrote:
>> This patch series removes the "individual" I2C commands (and the
>> CONFIG_I2C_CMD_TREE define) and migrates all boards to the newer
>> "tree style" I2C commands.
>>
>> A small amount of cleanup was performed before and after removing
>> the individual commands.
> 
> Thanks for your work, looks good to me. I make some tests
> with your patches, and if they are OK, I apply your patches to
> u-boot-i2c.git.
> 
> Hmm.. maybe you can have a look at my posting:
> 
> http://lists.denx.de/pipermail/u-boot/2009-March/049506.html
> 
> There is a new i2c_core.c file which holds all "common" i2c
> functions, for example the  i2c_[set|get]_bus_speed(). I
> think such a file is a better place for it.
> 
> I wonder I get no response for cleaning up the i2c subsystem ...
> is here no interest in doing such a cleanup? (I think it is
> a necessary step ...)
> 
> comments are welcome ;-)
> 
> bye
> Heiko

I am in favor of an i2c cleanup, and also Peter's changeover to the i2c 
"tree style" fix.  I would take the lack of opposition as tacit 
approval, rather than apathy.  Thankfully, the u-boot list isn't made up 
of a flock of dittoheads (def'n #2):
   <http://www.urbandictionary.com/define.php?term=dittohead>

Thanks,
gvb

  reply	other threads:[~2009-04-17 13:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-16 19:41 [U-Boot] [PATCH 0/7] Remove individual I2C commands and cleanup Peter Tyser
2009-04-16 19:41 ` [U-Boot] [PATCH 1/7] cm5200: Make function test command names more unique Peter Tyser
2009-04-16 19:41 ` [U-Boot] [PATCH 2/7] i2c: Create common default i2c_[set|get]_bus_speed() functions Peter Tyser
2009-04-18 18:23   ` Mike Frysinger
2009-04-19  3:13     ` Peter Tyser
2009-04-20  4:54       ` Mike Frysinger
2009-04-16 19:41 ` [U-Boot] [PATCH 3/7] i2c: Remove deprecated individual i2c commands Peter Tyser
2009-04-16 19:41 ` [U-Boot] [PATCH 4/7] i2c: Update references to " Peter Tyser
2009-04-16 19:41 ` [U-Boot] [PATCH 5/7] cmd_i2c: Clean up i2c command argument parsing Peter Tyser
2009-04-16 19:41 ` [U-Boot] [PATCH 6/7] cmd_i2c: Clean up trivial helper functions Peter Tyser
2009-04-16 19:41 ` [U-Boot] [PATCH 7/7] cmd_i2c: Fix i2c help command output when CONFIG_I2C_MUX Peter Tyser
2009-04-16 22:08 ` [U-Boot] [PATCH 0/7] Remove individual I2C commands and cleanup Timur Tabi
2009-04-17  6:20 ` Heiko Schocher
2009-04-17 13:32   ` Jerry Van Baren [this message]
2009-04-18  7:11     ` Heiko Schocher
2009-04-17 16:43   ` Peter Tyser
2009-04-18  7:14     ` Heiko Schocher
2009-04-23  6:18 ` [U-Boot] [PATCH v2 " Heiko Schocher
2009-04-23  7:02   ` Heiko Schocher
2009-04-23 23:06     ` Peter Tyser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49E884DC.2090204@ge.com \
    --to=gerald.vanbaren@ge.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox