From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH u-boot git] DaVinci Ethernet cleanup
Date: Sun, 19 Apr 2009 21:07:38 -0700 [thread overview]
Message-ID: <49EBF50A.6070001@gmail.com> (raw)
In-Reply-To: <20090417054119.GK31923@game.jcrosoft.org>
Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 15:49 Sun 12 Apr , David Brownell wrote:
>
>> From: David Brownell <dbrownell@users.sourceforge.net>
>>
>> Chips without the EMAC controller won't need the utilities
>> it uses to read an Ethernet address from EEPROM; so don't
>> include them needlessly.
>>
>> Use is_valid_ether() to validate the address from EEPROM.
>> All-zero addresses aren't the only invalid addresses.
>> A fully erased EEPROM returns all-ones, also invalid...
>>
>> Switch those Ethernet utilities to use "%pM" for printing
>> MAC addresses; and not say ROM when they mean EEPROM.
>>
>> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
>>
Acked-by: Ben Warren <biggerbadderben@gmail.com>
> Looks fine
>
> Ben any comments?
>
> Best Regards,
> J.
>
Please pull this in with the other changes.
regards,
Ben
next prev parent reply other threads:[~2009-04-20 4:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-12 22:49 [U-Boot] [PATCH u-boot git] DaVinci Ethernet cleanup David Brownell
2009-04-17 5:41 ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-20 4:07 ` Ben Warren [this message]
2009-04-27 22:33 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49EBF50A.6070001@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox