From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Warren Date: Sun, 19 Apr 2009 21:07:38 -0700 Subject: [U-Boot] [PATCH u-boot git] DaVinci Ethernet cleanup In-Reply-To: <20090417054119.GK31923@game.jcrosoft.org> References: <200904121549.26602.david-b@pacbell.net> <20090417054119.GK31923@game.jcrosoft.org> Message-ID: <49EBF50A.6070001@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Jean-Christophe PLAGNIOL-VILLARD wrote: > On 15:49 Sun 12 Apr , David Brownell wrote: > >> From: David Brownell >> >> Chips without the EMAC controller won't need the utilities >> it uses to read an Ethernet address from EEPROM; so don't >> include them needlessly. >> >> Use is_valid_ether() to validate the address from EEPROM. >> All-zero addresses aren't the only invalid addresses. >> A fully erased EEPROM returns all-ones, also invalid... >> >> Switch those Ethernet utilities to use "%pM" for printing >> MAC addresses; and not say ROM when they mean EEPROM. >> >> Signed-off-by: David Brownell >> Acked-by: Ben Warren > Looks fine > > Ben any comments? > > Best Regards, > J. > Please pull this in with the other changes. regards, Ben