public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 0/7] Remove individual I2C commands and cleanup
Date: Thu, 23 Apr 2009 09:02:28 +0200	[thread overview]
Message-ID: <49F01284.3080507@denx.de> (raw)
In-Reply-To: <49F0081F.9030409@denx.de>

Hello Peter,

Heiko Schocher wrote:
> Peter Tyser wrote:
>> This patch series removes the "individual" I2C commands (and the
>> CONFIG_I2C_CMD_TREE define) and migrates all boards to the newer
>> "tree style" I2C commands.
>>
>> A small amount of cleanup was performed before and after removing
>> the individual commands.
>>
>> Peter Tyser (7):
>>   cm5200: Make function test command names more unique
>>   cmd_i2c: Create common default i2c_[set|get]_bus_speed() functions
>>   cmd_i2c: Remove deprecated individual i2c commands
>>   cmd_i2c: Update references to individual i2c commands
>>   cmd_i2c: Clean up i2c command argument parsing
>>   cmd_i2c: Clean up trivial helper functions
>>   cmd_i2c: Fix i2c help command output when CONFIG_I2C_MUX
>>
>> Changes since v1:
>> - replaced __attribute references with __attribute__
> 
> Applied to u-boot-i2c.git next branch
> Thanks!

Damned, I should have wait for the "MAKEALL" is finished ... the nearly
two last boards showed me the following error:

Configuring for CPCI750 board...
cmd_i2c.c: In function 'do_i2c':
cmd_i2c.c:1286: error: 'CONFIG_SYS_I2C_SLAVE' undeclared (first use in this function)
cmd_i2c.c:1286: error: (Each undeclared identifier is reported only once
cmd_i2c.c:1286: error: for each function it appears in.)
make[1]: *** [cmd_i2c.o] Fehler 1
make[1]: *** Warte auf noch nicht beendete Prozesse...
make: *** [common/libcommon.a] Fehler 2
ppc_82xx-size: './u-boot': No such file
Configuring for ELPPC board...
   text    data     bss     dec     hex filename
 169744   19652   38320  227716   37984 ./u-boot
Configuring for p3mx board...
cmd_i2c.c: In function 'do_i2c':
cmd_i2c.c:1286: error: 'CONFIG_SYS_I2C_SLAVE' undeclared (first use in this function)
cmd_i2c.c:1286: error: (Each undeclared identifier is reported only once
cmd_i2c.c:1286: error: for each function it appears in.)
make[1]: *** [cmd_i2c.o] Fehler 1
make[1]: *** Warte auf noch nicht beendete Prozesse...
make: *** [common/libcommon.a] Fehler 2
ppc_82xx-size: './u-boot': No such file

This is introduced from your patch
[PATCH v2 3/7] i2c: Remove deprecated individual i2c commands
from your patchseries ... can you please fix this?

thanks
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2009-04-23  7:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-16 19:41 [U-Boot] [PATCH 0/7] Remove individual I2C commands and cleanup Peter Tyser
2009-04-16 19:41 ` [U-Boot] [PATCH 1/7] cm5200: Make function test command names more unique Peter Tyser
2009-04-16 19:41 ` [U-Boot] [PATCH 2/7] i2c: Create common default i2c_[set|get]_bus_speed() functions Peter Tyser
2009-04-18 18:23   ` Mike Frysinger
2009-04-19  3:13     ` Peter Tyser
2009-04-20  4:54       ` Mike Frysinger
2009-04-16 19:41 ` [U-Boot] [PATCH 3/7] i2c: Remove deprecated individual i2c commands Peter Tyser
2009-04-16 19:41 ` [U-Boot] [PATCH 4/7] i2c: Update references to " Peter Tyser
2009-04-16 19:41 ` [U-Boot] [PATCH 5/7] cmd_i2c: Clean up i2c command argument parsing Peter Tyser
2009-04-16 19:41 ` [U-Boot] [PATCH 6/7] cmd_i2c: Clean up trivial helper functions Peter Tyser
2009-04-16 19:41 ` [U-Boot] [PATCH 7/7] cmd_i2c: Fix i2c help command output when CONFIG_I2C_MUX Peter Tyser
2009-04-16 22:08 ` [U-Boot] [PATCH 0/7] Remove individual I2C commands and cleanup Timur Tabi
2009-04-17  6:20 ` Heiko Schocher
2009-04-17 13:32   ` Jerry Van Baren
2009-04-18  7:11     ` Heiko Schocher
2009-04-17 16:43   ` Peter Tyser
2009-04-18  7:14     ` Heiko Schocher
2009-04-23  6:18 ` [U-Boot] [PATCH v2 " Heiko Schocher
2009-04-23  7:02   ` Heiko Schocher [this message]
2009-04-23 23:06     ` Peter Tyser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49F01284.3080507@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox