public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Daniel Gorsulowski <Daniel.Gorsulowski@esd.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] Bug in new at91 clock framework?
Date: Thu, 23 Apr 2009 15:44:09 +0200	[thread overview]
Message-ID: <49F070A9.6060801@esd.eu> (raw)
In-Reply-To: <20090423125959.GC18705@game.jcrosoft.org>

Jean-Christophe PLAGNIOL-VILLARD schrieb:
>> I'm working on git://git.denx.de/u-boot-at91.git branch clock
>> I also have an AT91SAM9263-EK, but with a 16.0 MHz main oscillator.
>> Everything is fine, as long as no changes were made. But if I undef
>> CONFIG_USB_ATMEL and CONFIG_CMD_USB, the board does not boot. Only
>> some cryptical characters appear after the "RomBOOT" term. It's the
>> same behavior as on my own board.
> use git://git.denx.de/u-boot-at91.git branch master
> 
> Best Regards,
> J.
> 
Thank you, it works now. But I have to apply the attached patch.
Otherwise, I get a compiler error
cpu/arm926ejs/at91/libat91.a(clock.o): In function `at91_clock_init':
/data/home/danielg/git/u-boot-at91_new/cpu/arm926ejs/at91/clock.c:167: undefined reference to `at91_pll_rate'

---
 From 730db691fabf958d1b3d74e678f7f47a0776df16 Mon Sep 17 00:00:00 2001
From: Daniel Gorsulowski <Daniel.Gorsulowski@esd.eu>
Date: Thu, 23 Apr 2009 15:37:16 +0200
Subject: [PATCH] at91: fixed cpu/arm926ejs/at91/clock.c

Signed-off-by: Daniel Gorsulowski <Daniel.Gorsulowski@esd.eu>
---
  cpu/arm926ejs/at91/clock.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/cpu/arm926ejs/at91/clock.c b/cpu/arm926ejs/at91/clock.c
index 31e53b3..f776f70 100644
--- a/cpu/arm926ejs/at91/clock.c
+++ b/cpu/arm926ejs/at91/clock.c
@@ -126,6 +126,7 @@ static unsigned at91_pll_calc(unsigned main_freq, unsigned out_freq)
  fail:
  	return 0;
  }
+#endif

  static u32 at91_pll_rate(u32 freq, u32 reg)
  {
@@ -141,7 +142,6 @@ static u32 at91_pll_rate(u32 freq, u32 reg)

  	return freq;
  }
-#endif

  int at91_clock_init(unsigned long main_clock)
  {
-- 
1.6.1

  reply	other threads:[~2009-04-23 13:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-07 12:31 [U-Boot] [PATCH 1/2] at91: Add command to control up to 5 user-leds from the console Daniel Gorsulowski
2009-04-07 12:31 ` [U-Boot] [PATCH 2/2] at91: Add support for MEESC board of esd gmbh Daniel Gorsulowski
2009-04-17  6:00   ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-22 10:15     ` [U-Boot] Bug in new at91 clock framework? Daniel Gorsulowski
     [not found]       ` <20090422131402.GA29252@game.jcrosoft.org>
2009-04-23 10:38         ` Daniel Gorsulowski
2009-04-23 12:59           ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-23 13:44             ` Daniel Gorsulowski [this message]
2009-04-17  5:51 ` [U-Boot] [PATCH 1/2] at91: Add command to control up to 5 user-leds from the console Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49F070A9.6060801@esd.eu \
    --to=daniel.gorsulowski@esd.eu \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox