From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] netloop: updates for NetLoop
Date: Fri, 24 Apr 2009 16:41:22 -0700 [thread overview]
Message-ID: <49F24E22.8070805@gmail.com> (raw)
In-Reply-To: <20090424194524.E43E983420E8@gemini.denx.de>
Hi Wolfgang,
Wolfgang Denk wrote:
> Dear Ben,
>
> In message <20090403215728.930BE83797DC@gemini.denx.de> I wrote:
>
>> Dear Ben,
>>
>> In message <49A641E4.8000001@denx.de> you wrote:
>>
>>> [PATCH v2] netloop: updates for NetLoop
>>>
>>> Fix some issues introduced from commit:
>>> 2f70c49e5b9813635ad73666aa30f304c7fdeda9
>>> suggested by Mike Frysinger.
>>>
>>> - added some comment for the env_id variable in common_cmd_nvedit.c
>>> - moved some variables in fn scope instead of file scope
>>> - NetInitLoop now static void
>>>
>>> Signed-off-by: Heiko Schocher <hs@denx.de>
>>> ---
>>> changes since v1:
>>> - added comments from Mike Frysinger
>>>
>>> common/cmd_nvedit.c | 7 +++++++
>>> net/eth.c | 5 ++---
>>> net/net.c | 8 +++-----
>>> 3 files changed, 12 insertions(+), 8 deletions(-)
>>>
>> Except for an Ack from Mike I did not see any comments?
>>
>> Ditto for this one:
>>
>> http://article.gmane.org/gmane.comp.boot-loaders.u-boot/55341
>>
>
> Please comment -- if you want, I can apply directly.
>
> Best regards,
>
> Wolfgang Denk
>
Sorry, thought I was caught up. This looks good - please apply directly.
thanks,
Ben
next prev parent reply other threads:[~2009-04-24 23:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 12:40 [U-Boot] [PATCH] netloop: updates for NetLoop Heiko Schocher
2009-02-25 17:01 ` Mike Frysinger
2009-02-26 7:16 ` [U-Boot] [PATCH v2] " Heiko Schocher
2009-02-26 8:47 ` Mike Frysinger
2009-04-03 21:57 ` Wolfgang Denk
2009-04-03 23:28 ` Michael Zaidman
2009-04-24 19:45 ` Wolfgang Denk
2009-04-24 23:41 ` Ben Warren [this message]
2009-04-27 22:09 ` Wolfgang Denk
2009-04-28 5:41 ` [U-Boot] [PATCH] [PATCH v3] " Heiko Schocher
2009-04-28 7:09 ` Ben Warren
2009-04-28 6:21 ` Heiko Schocher
2009-04-28 6:36 ` [U-Boot] [PATCH v4] " Heiko Schocher
2009-04-28 17:22 ` Ben Warren
2009-05-15 19:18 ` Wolfgang Denk
2009-05-15 19:18 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F24E22.8070805@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox