From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH u-boot git] dm9000 EEPROM reading bugfix
Date: Sat, 25 Apr 2009 00:44:00 -0700 [thread overview]
Message-ID: <49F2BF40.7080207@gmail.com> (raw)
In-Reply-To: <200904162315.15209.david-b@pacbell.net>
Wolfgang,
David Brownell wrote:
> From: David Brownell <dbrownell@users.sourceforge.net>
>
> Make the U-Boot dm9000 driver read addresses from EEPROM just
> like Linux does ... read six bytes, instead of reading twelve
> bytes and then discarding every other one.
>
> Using the right Ethernet address is a big win.
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> ---
> drivers/net/dm9000x.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> --- a/drivers/net/dm9000x.c
> +++ b/drivers/net/dm9000x.c
> @@ -113,7 +113,7 @@ void eth_halt(void);
> static int dm9000_probe(void);
> static u16 phy_read(int);
> static void phy_write(int, u16);
> -u16 read_srom_word(int);
> +static void read_srom_word(int, u8 *);
> static u8 DM9000_ior(int);
> static void DM9000_iow(int reg, u8 value);
>
> @@ -348,8 +348,8 @@ eth_init(bd_t * bd)
> /* Set Node address */
> if (!eth_getenv_enetaddr("ethaddr", enetaddr)) {
> #if !defined(CONFIG_AT91SAM9261EK)
> - for (i = 0; i < 6; i++)
> - enetaddr[i] = read_srom_word(i);
> + for (i = 0; i < 3; i++)
> + read_srom_word(i, enetaddr + 2 * i);
> eth_setenv_enetaddr("ethaddr", enetaddr);
> #endif
> }
> @@ -541,14 +541,14 @@ eth_rx(void)
> /*
> Read a word data from SROM
> */
> -u16
> -read_srom_word(int offset)
> +static void read_srom_word(int offset, u8 *to)
> {
> DM9000_iow(DM9000_EPAR, offset);
> DM9000_iow(DM9000_EPCR, 0x4);
> udelay(8000);
> DM9000_iow(DM9000_EPCR, 0x0);
> - return (DM9000_ior(DM9000_EPDRL) + (DM9000_ior(DM9000_EPDRH) << 8));
> + to[0] = DM9000_ior(DM9000_EPDRL);
> + to[1] = DM9000_ior(DM9000_EPDRH);
> }
>
> void
>
> ____
Please apply this directly. I incorrectly looked at it as a feature
rather than a bug fix.
regards,
Ben
next prev parent reply other threads:[~2009-04-25 7:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-12 22:35 [U-Boot] [PATCH u-boot git] dm9000 EEPROM reading bugfix David Brownell
2009-04-12 23:04 ` David Brownell
2009-04-17 5:38 ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-17 6:15 ` David Brownell
2009-04-17 7:29 ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-20 4:09 ` Ben Warren
2009-04-25 7:44 ` Ben Warren [this message]
2009-04-27 22:28 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F2BF40.7080207@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox