From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dirk Behme Date: Sun, 26 Apr 2009 06:34:28 +0200 Subject: [U-Boot] Using Signed-off-by, was: OMAP3: Print correct silicon revision In-Reply-To: <20090425125202.GE25381@game.jcrosoft.org> References: <1240584727-6936-1-git-send-email-premi@ti.com> <49F1EDA4.6030903@googlemail.com> <20090424200623.GF2953@game.jcrosoft.org> <49F223D8.1090205@googlemail.com> <20090425125202.GE25381@game.jcrosoft.org> Message-ID: <49F3E454.70708@googlemail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Jean-Christophe, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 22:40 Fri 24 Apr , Dirk Behme wrote: >> Dear Jean-Christophe, >> >> Jean-Christophe PLAGNIOL-VILLARD wrote: >>> On 18:49 Fri 24 Apr , Dirk Behme wrote: >>>> Sanjeev Premi wrote: >>>>> The function display_board_info() displays incorrect >>>>> silicon revision - based on the return value from >>>>> function get_cpu_rev(). >>>>> >>>>> This patch fixes the problem. >>>>> >>>>> Signed-off-by: Sanjeev Premi >>>> Signed-off-by: Dirk Behme >>>> Tested-by: Dirk Behme >>> why the twice? >> I wanted to mention that I helped developing these patches and that I >> tested them on real HW. > what do you mean by help? > review or dev? Sorry, but I can't see what might be unclear with the string 'helped developing' I used regarding your question. > if it's review I do not think the sob is correct Please elaborate more why in review case you think sob is not correct? Dirk